Re: master c6dd8dd: * lisp/emacs-lisp/macroexp.el: Improve last change

[Lars Ingebrigtsen]

Stefan Kangas <stefankangas@gmail.com> writes:

>>>     Don't burp when `byte-compile-warning-enabled-p` is not yet defined.
>>>     And use the call that we had already instead of adding a new one.
>>
>> This (or something else recently) seems to lead to a failure in
>
> I've just finished bisecting these recently introduced errors and this
> commit is indeed the culprit.

I've now changed it to not bug out, but I haven't looked closely at the
logic -- why is the `warning' a nil there anyway?

> I'm seeing this as well:
>
> 4 files did not contain any tests:
>   lisp/net/ntlm-tests.log
>   lisp/emacs-lisp/eieio-tests/eieio-tests.log
>   lisp/emacs-lisp/eieio-tests/eieio-test-persist.log
>   lisp/cedet/srecode/fields-tests.log
>
> With errors like:
>
> In toplevel form:
> lisp/emacs-lisp/eieio-tests/eieio-tests.el:36:1: Error: Wrong number
> of arguments: #<subr byte-compile-warning-enabled-p>, 0
> make[3]: *** [Makefile:165: lisp/emacs-lisp/eieio-tests/eieio-tests.elc] 
> Error 1

These also seem to work now...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no