[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Zero byte-compiler warnings in the test suite
From: |
Stefan Kangas |
Subject: |
Re: Zero byte-compiler warnings in the test suite |
Date: |
Tue, 21 Dec 2021 05:39:08 -0800 |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> But with a native-comp build (at least), I'm getting two
> warnings/errors on the current trunk:
>
> In toplevel form:
> lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:273:1: Warning:
> ‘defgeneric’ is an obsolete macro (as of 25.1); use ‘cl-defgeneric’ instead.
Strange, I don't see that here (with native-comp). Does this help?
diff --git a/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el
b/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el
index e881e46a2d..bc89f23b58 100644
--- a/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el
+++ b/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el
@@ -271,6 +271,7 @@ E-base2
(defclass E (E-base1 E-base2) () :method-invocation-order :breadth-first)
(with-suppressed-warnings ((obsolete defmethod)
+ (obsolete defgeneric)
(obsolete next-method-p)
(obsolete call-next-method))
(defmethod eitest-F ((_p E))
> Compiler-macro error for cl-typep: (error "Unknown type notatype")
> Compiler-macro error for cl-typep: (error "Unknown type notatype")
> Compiler-macro error for cl-typep: (error "Unknown type notatype")
> Compiler-macro error for cl-typep: (error "Unknown type notatype")
> Compiler-macro error for cl-typep: (error "Unknown type notatype")
I've seen these as well, but they weren't counted by compilation-mode so
I just sort of ignored them. It would be good to fix them as well of
course.
AFAICT, they come from here:
ELC+ELN lisp/emacs-lisp/pcase-tests.elc
Compiler-macro error for cl-typep: (error "Unknown type notatype")
Compiler-macro error for cl-typep: (error "Unknown type notatype")
Compiler-macro error for cl-typep: (error "Unknown type notatype")
Compiler-macro error for cl-typep: (error "Unknown type notatype")
Compiler-macro error for cl-typep: (error "Unknown type notatype")
GEN lisp/emacs-lisp/pcase-tests.log
Grepping for notatype leads me to:
./lisp/emacs-lisp/pcase-tests.el:111: ((cl-type
notatype) 'integer))))
Does anyone know what is going on here?
- Zero byte-compiler warnings in the test suite, Stefan Kangas, 2021/12/21
- Re: Zero byte-compiler warnings in the test suite, Lars Ingebrigtsen, 2021/12/21
- Re: Zero byte-compiler warnings in the test suite,
Stefan Kangas <=
- Re: Zero byte-compiler warnings in the test suite, Stefan Monnier, 2021/12/21
- Re: Zero byte-compiler warnings in the test suite, Stefan Kangas, 2021/12/22
- Re: Zero byte-compiler warnings in the test suite, Stefan Monnier, 2021/12/22
- Re: Zero byte-compiler warnings in the test suite, Stefan Kangas, 2021/12/22
- Weird non-caught error in ERT (was: Zero byte-compiler warnings in the test suite), Stefan Monnier, 2021/12/22
- Re: Weird non-caught error in ERT (was: Zero byte-compiler warnings in the test suite), Philipp Stephani, 2021/12/23
Re: Zero byte-compiler warnings in the test suite, Eli Zaretskii, 2021/12/21