[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Zero byte-compiler warnings in the test suite
From: |
Stefan Monnier |
Subject: |
Re: Zero byte-compiler warnings in the test suite |
Date: |
Tue, 21 Dec 2021 10:41:12 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
> Compiler-macro error for cl-typep: (error "Unknown type notatype")
> GEN lisp/emacs-lisp/pcase-tests.log
>
> Grepping for notatype leads me to:
>
> ./lisp/emacs-lisp/pcase-tests.el:111: ((cl-type
> notatype) 'integer))))
>
> Does anyone know what is going on here?
I thought it was pretty obvious: `c-type` takes a type as argument, but
`notatype` is ... not declared as a type, so we get an error.
The test expects the error to be signal'd at run time whereas the
compiler macro prefers to signal the error right away.
As a bias observer, I'd suggest to fix the test rather than the compiler
macro ;-)
Stefan
- Zero byte-compiler warnings in the test suite, Stefan Kangas, 2021/12/21
- Re: Zero byte-compiler warnings in the test suite, Lars Ingebrigtsen, 2021/12/21
- Re: Zero byte-compiler warnings in the test suite, Stefan Kangas, 2021/12/21
- Re: Zero byte-compiler warnings in the test suite,
Stefan Monnier <=
- Re: Zero byte-compiler warnings in the test suite, Stefan Kangas, 2021/12/22
- Re: Zero byte-compiler warnings in the test suite, Stefan Monnier, 2021/12/22
- Re: Zero byte-compiler warnings in the test suite, Stefan Kangas, 2021/12/22
- Weird non-caught error in ERT (was: Zero byte-compiler warnings in the test suite), Stefan Monnier, 2021/12/22
- Re: Weird non-caught error in ERT (was: Zero byte-compiler warnings in the test suite), Philipp Stephani, 2021/12/23
Re: Zero byte-compiler warnings in the test suite, Eli Zaretskii, 2021/12/21