emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 38697a07c0 1/2: Add :safe property to ffap-machine-p-* variab


From: Eli Zaretskii
Subject: Re: master 38697a07c0 1/2: Add :safe property to ffap-machine-p-* variables
Date: Fri, 08 Jul 2022 15:47:09 +0300

> branch: master
> commit 38697a07c0f2b99b76c41cb1096543681342a405
> Author: Stefan Kangas <stefan@marxist.se>
> Commit: Stefan Kangas <stefan@marxist.se>
> 
>     Add :safe property to ffap-machine-p-* variables
>     
>     * lisp/ffap.el (ffap--accept-or-reject-p): New predicate defun.
>     (ffap-machine-p-local, ffap-machine-p-known)
>     (ffap-machine-p-unknown): Add :safe property using above new
>     predicate.

This uses an internal function as the value of a property of a user
option, which I think is not a good idea.  How about making the
function public instead (and changing its name to
'ffap-accept-or-reject-p' while at that)?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]