|
From: | Stefan Monnier |
Subject: | Re: Special Event: Davin reveals his own personal additions to Emacs. |
Date: | Tue, 12 Jul 2022 23:08:50 -0400 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
>> Parenthesis shall end together, not like this: >> >> (defun manifest--log-message (msg) >> (save-excursion >> (set-buffer manifest--buffer) >> (goto-char (point-max)) >> (setq latest-file (manifest--get-latest-file)) >> (insert msg "\n") >> ) >> ) >> >> rather like: >> >> (defun manifest--log-message (msg) >> (save-excursion >> (set-buffer manifest--buffer) >> (goto-char (point-max)) >> (setq latest-file (manifest--get-latest-file)) >> (insert msg "\n"))) I dislike those close-parens-on-their-own-lines as well, but more importantly: - should use `with-current-buffer`. - should not `setq` on a global variable that doesn't have an appropriate namespace prefix. Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |