emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PROPOSAL: New function ffap-ip-at-point


From: Robert Pluim
Subject: Re: PROPOSAL: New function ffap-ip-at-point
Date: Sat, 23 Jul 2022 09:31:16 +0200

>>>>> On Fri, 22 Jul 2022 22:10:41 +0200, Lars Ingebrigtsen <larsi@gnus.org> 
>>>>> said:

    Lars> Iñigo Serna <inigoserna@gmx.com> writes:
    >> 'textsec--ipvx-address-p' current implementation is not perfect.
    >> It returns a wrong result when some octet is greater than 255.
    >> 
    >> (textsec--ipvx-address-p "343.1.2.3")
    >> 0
    >> 
    >> (ffap-ipv4-p "343.1.2.3")
    >> nil
    >> 
    >> So IMO it's not as useful for my purposes, reports from network tools.

    Lars> Well, we could trivially fix that in that function.

How far down the rabbit hole do we want to go, knowing that libc has
already done this? Note: "0343.1.2.3" is a valid representation of an
IPv4 address, as is "0", or "1".

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]