[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: feature/fix-the-long-lines-display-bug e7b5912b23: Improvements to l
From: |
Robert Pluim |
Subject: |
Re: feature/fix-the-long-lines-display-bug e7b5912b23: Improvements to long lines handling. |
Date: |
Sun, 24 Jul 2022 14:10:33 +0200 |
>>>>> On Sun, 24 Jul 2022 14:45:09 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org,
gregory@heytings.org
>> Gmane-Reply-To-List: yes
>> Date: Sun, 24 Jul 2022 13:14:21 +0200
>>
>> Apropos, is there an ʼupdating pdumper stuff for dummiesʼ guide
>> somewhere? Something along the lines of:
>> - if you add an int to struct <foo>, do <bar>
>> - if you add a Lisp_Object to struct <baz>, do <frot>
>>
>> I ask, because Iʼm playing with struct buffer_text, and Iʼm very
>> successfully causing 'failure to dump' :-)
Eli> The error message points you to the comment in config.h that is
Eli> supposed to be the "updating pdumper stuff for dummies" guide:
Eli> error: #error "buffer changed. See CHECK_STRUCTS comment in
config.h."
Sorry, I wasnʼt clear. That just fixes the compile error, it doesnʼt
cover the second part, which is to ensure that your new field is
dumped/restored correctly. For a struct Lisp_Hash_Table *,
DUMP_FIELD_COPY is not enough.
Robert
--