[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Inferred function types in the *Help* buffer
From: |
Andrea Corallo |
Subject: |
Re: Inferred function types in the *Help* buffer |
Date: |
Thu, 01 Jun 2023 10:09:56 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
[...]
> Either I misunderstood what a return value of `boolean` means, or that
> list is riddled with errors. The following functions are specified to
> return boolean in comp-known-type-specifiers but actually may return
> other values as well:
>
> proper-list-p
> buffer-modified-p
> coordinates-in-window-p
> custom-variable-p
> file-locked-p
> file-symlink-p
> frame-visible-p
> framep
Okay the attached should address these (please have a look if/when
you've time).
> and, since we have no guarantees about what file handlers actually return,
>
> file-directory-p
> file-exists-p
> file-newer-than-file-p
> file-readable-p
> file-writable-p
Aren't the entries we have in agreement with the docstring? If the
docstring is not in sync with the implementation we have either to fix
one o the other I think.
Thanks!
Andrea
>From 59383af6b309cd4f6b0340d7d1c8fd90ac71d569 Mon Sep 17 00:00:00 2001
From: Andrea Corallo <akrl@sdf.org>
Date: Thu, 1 Jun 2023 15:53:39 +0200
Subject: [PATCH] * lisp/emacs-lisp/comp.el (comp-known-type-specifiers): Fix a
bunch of
---
lisp/emacs-lisp/comp.el | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index b2704ae1446..d361b312a60 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -317,7 +317,7 @@ comp-known-type-specifiers
(buffer-file-name (function (&optional buffer) (or string null)))
(buffer-list (function (&optional frame) list))
(buffer-local-variables (function (&optional buffer) list))
- (buffer-modified-p (function (&optional buffer) boolean))
+ (buffer-modified-p (function (&optional buffer) (or boolean (member
autosaved))))
(buffer-size (function (&optional buffer) integer))
(buffer-string (function () string))
(buffer-substring (function ((or integer marker) (or integer marker))
string))
@@ -344,7 +344,7 @@ comp-known-type-specifiers
(concat (function (&rest sequence) string))
(cons (function (t t) cons))
(consp (function (t) boolean))
- (coordinates-in-window-p (function (cons window) boolean))
+ (coordinates-in-window-p (function (cons window) (or cons (member
bottom-divider right-divider mode-line header-line
tab-lineleft-fringeright-fringevertical-line left-margin right-margin))))
(copy-alist (function (list) list))
(copy-marker (function (&optional (or integer marker) boolean) marker))
(copy-sequence (function (sequence) sequence))
@@ -363,7 +363,7 @@ comp-known-type-specifiers
(current-time-zone (function (&optional (or number list)
(or symbol string cons integer))
cons))
- (custom-variable-p (function (symbol) boolean))
+ (custom-variable-p (function (symbol) t))
(decode-char (function (cons t) (or fixnum null)))
(decode-time (function (&optional (or number list)
(or symbol string cons integer)
@@ -392,11 +392,11 @@ comp-known-type-specifiers
(ffloor (function (float) float))
(file-directory-p (function (string) boolean))
(file-exists-p (function (string) boolean))
- (file-locked-p (function (string) boolean))
+ (file-locked-p (function (string) (or boolean string)))
(file-name-absolute-p (function (string) boolean))
(file-newer-than-file-p (function (string string) boolean))
(file-readable-p (function (string) boolean))
- (file-symlink-p (function (string) boolean))
+ (file-symlink-p (function (string) (or boolean string)))
(file-writable-p (function (string) boolean))
(fixnump (function (t) boolean))
(float (function (number) float))
@@ -411,8 +411,8 @@ comp-known-type-specifiers
(frame-first-window (function ((or frame window)) window))
(frame-root-window (function (&optional (or frame window)) window))
(frame-selected-window (function (&optional (or frame window)) window))
- (frame-visible-p (function (frame) boolean))
- (framep (function (t) boolean))
+ (frame-visible-p (function (frame) (or boolean (member icon))))
+ (framep (function (t) (or boolean (member x w32 ns pc pgtk haiku))))
(fround (function (float) float))
(ftruncate (function (float) float))
(get (function (symbol symbol) t))
@@ -506,7 +506,7 @@ comp-known-type-specifiers
(previous-window (function (&optional window t t) window))
(prin1-to-string (function (t &optional t t) string))
(processp (function (t) boolean))
- (proper-list-p (function (t) boolean))
+ (proper-list-p (function (t) (or fixnum null)))
(propertize (function (string &rest t) string))
(radians-to-degrees (function (number) float))
(rassoc (function (t list) list))
--
2.25.1
- Re: Inferred function types in the *Help* buffer, (continued)
- Re: Inferred function types in the *Help* buffer, Andrea Corallo, 2023/06/01
- Re: Inferred function types in the *Help* buffer, Mattias Engdegård, 2023/06/01
- Re: Inferred function types in the *Help* buffer, Andrea Corallo, 2023/06/01
- Re: Inferred function types in the *Help* buffer, Mattias Engdegård, 2023/06/01
- Re: Inferred function types in the *Help* buffer, Andrea Corallo, 2023/06/01
- Re: Inferred function types in the *Help* buffer, Mattias Engdegård, 2023/06/01
- Re: Inferred function types in the *Help* buffer, Andrea Corallo, 2023/06/01
- Re: Inferred function types in the *Help* buffer,
Andrea Corallo <=