emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 8657afac774: Correct conversion of strings to tree-sitter que


From: Michael Albinus
Subject: Re: master 8657afac774: Correct conversion of strings to tree-sitter query syntax
Date: Sat, 17 Jun 2023 10:30:37 +0200
User-agent: Gnus/5.13 (Gnus v5.13)

Mattias Engdegård <mattiase@acm.org> writes:

Hi,

> branch: master
> commit 8657afac774f36777d0fdd368e0bec64beca22ae
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
>     Correct conversion of strings to tree-sitter query syntax
>     
>     The treesitter query syntax for string literals differs from that of
>     Elisp so we cannot just use the Lisp printer (bug#64017).
>     
>     * src/treesit.c (treesit_query_string_string): New function.
>     (Ftreesit_pattern_expand): Use it.
>     * test/src/treesit-tests.el (treesit-query-api): Add test case.

I'm not sure it is because of *this* change, but tree-sitter tests on
emba fail now:

--8<---------------cut here---------------start------------->8---
Test ruby-ts-syntax-propertize-symbol condition:
    (ert-test-failed
     ((should
       (equal-including-properties text expected))
      :form
      (equal-including-properties ":foo?"
                                  #(":foo?" 4 5
                                    (syntax-table ...)))
      :value nil :explanation
      (char 4 "?"
            (different-properties-for-key syntax-table
                                          (different-types nil ...))
            context-before ":foo" context-after "")))
   FAILED  21/21  ruby-ts-syntax-propertize-symbol (0.001835 sec) at 
lisp/progmodes/ruby-ts-mode-tests.el:261
--8<---------------cut here---------------end--------------->8---

See for example <https://emba.gnu.org/emacs/emacs/-/jobs/69060>.

Best regards, Michael.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]