[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Android port
From: |
Paul Eggert |
Subject: |
Re: Android port |
Date: |
Sun, 6 Aug 2023 10:44:09 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 |
On 2023-08-06 05:20, Po Lu wrote:
That being said, I'm reluctant to remove the printf-posix module at this
stage of the port's development. Emacs has undergone extensive testing
on all supported versions of Android with the Gnulib printf, and hardly
any at all without.
I understand the reluctance from the Android point of view. However,
printf-posix imports 69 new source files to Emacs, and these files have
not been tested extensively with Emacs on non-Android platforms. From
the viewpoint of non-Android Emacs platforms, it's significantly less
disruptive if merging the Android branch does not add 69 new source
files that will require testing on these platforms.
And even from the Android viewpoint, no matter what we do to fix the
problem some testing needs to be done anyway, as the fix is likely to
affect Emacs in test-relevant ways.
So I propose that we merge the master branch into feature/android (to
get the recent fix to stop using %n) and then apply the attached
patches. The first and third patches are the actual idea. The second
patch (compressed to save space) is automatically generated via
admin/merge-gnulib, and consists of deleting the 69 source files.
The idea is to get feature/android merged quickly. We can revisit the
use of Gnulib's printf-posix module later, as needed. With luck
printf-posix won't be needed, as Emacs historically has avoided use of
unusual printf features (for obvious portability reasons).
0001-Omit-Gnulib-printf-posix-and-vasnprintf-posix.patch
Description: Text Data
0002-Regenerate-by-running-admin-merge-gnulib.patch.gz
Description: application/gzip
0003-Do-not-define-HAVE_CONFIG_H.patch
Description: Text Data
- Re: Android port, (continued)
- Re: Android port, Bruno Haible, 2023/08/06
- Re: Android port, Po Lu, 2023/08/06
- Re: Android port, Eli Zaretskii, 2023/08/06
- Re: Android port, Po Lu, 2023/08/06
- Re: Android port, Bruno Haible, 2023/08/06
- Re: Android port, Po Lu, 2023/08/06
- Re: Android port, Eli Zaretskii, 2023/08/06
- Re: Android port, Bruno Haible, 2023/08/06
- Re: Android port, Paul Eggert, 2023/08/06
- Re: Android port, Eli Zaretskii, 2023/08/06
- Re: Android port,
Paul Eggert <=
- Re: Android port, Eli Zaretskii, 2023/08/06
- Re: Android port, Po Lu, 2023/08/06
- Re: Android port, Po Lu, 2023/08/06
- Re: Android port, Eli Zaretskii, 2023/08/07
- Re: Android port, Eli Zaretskii, 2023/08/07
- Re: Android port, Eli Zaretskii, 2023/08/07
Re: Android port, Po Lu, 2023/08/04