Re: ELPA git repo contains zero-padded file modes and running ~$ make fails

[Stefan Monnier]

[ Hi Omar, adding you to the discussion, see below why.  ]

>>>>> I have this error when git-pulling the elpa repository:
>
>>>>>   guerry git/elpa ‹master› » git pull
>>>>>   remote: Counting objects: 64150, done.
>>>>>   remote: Compressing objects: 100% (22564/22564), done.
>>>>>   error: object 2699d230e3b592ae42506d7b5c969a7ac6a4593c:
>>>>> zeroPaddedFilemode: contains zero-padded file modes
>>>>>   fatal: erreur de fsck dans l'objet empaqueté
>>>>>   fatal: échec de index-pack

Hmm... I thought I had fixed that.

I just tested it and I get something yet different from the expected:

    % git -c fetch.fsck.zeroPaddedFilemode=error clone 
git://git.sv.gnu.org/emacs/elpa
    Clonage dans 'elpa'...
    remote: Counting objects: 555187, done.
    remote: Compressing objects: 100% (165071/165071), done.
    erreur : object b7550f84d72a158e20aa425ea2a8f24b9ee9bac0: badDateOverflow: 
invalid author/committer line - date causes integer overflow
    fatal : erreur de fsck dans l'objet empaqueté
    fatal : fetch-pack : sortie d'index de pack invalide

[ Pardon my French 🙂 ]

Looking at the offending data:

    % git show b7550f84d72a158e20aa425ea2a8f24b9ee9bac0)
    commit b7550f84d72a158e20aa425ea2a8f24b9ee9bac0
    Author: Omar Antolín Camarena <omar.antolin@gmail.com>
    Date:   Thu Jan 1 00:00:00 1970 +0000
    
        When deciding if a candidate is selected compare original targets

And indeed:

    % git -c fetch.fsck.zeroPaddedFilemode=warn -c 
fetch.fsck.badDateOverflow=warn clone https://github.com/oantolin/embark
    Clonage dans 'embark'...
    remote: Enumerating objects: 5164, done.
    remote: Counting objects: 100% (830/830), done.
    remote: Compressing objects: 100% (314/314), done.
    avertissement : object b7550f84d72a158e20aa425ea2a8f24b9ee9bac0: 
badDateOverflow: invalid author/committer line - date causes integer overflow
    avertissement : object b7550f84d72a158e20aa425ea2a8f24b9ee9bac0: 
badDateOverflow: invalid author/committer line - date causes integer overflow
    avertissement : object 2b2e62af001312a9b97724855855dfec51b5bec6: 
badDateOverflow: invalid author/committer line - date causes integer overflow
    avertissement : object 2b2e62af001312a9b97724855855dfec51b5bec6: 
badDateOverflow: invalid author/committer line - date causes integer overflow
    remote: Total 5164 (delta 552), reused 790 (delta 516), pack-reused 4334
    Réception d'objets: 100% (5164/5164), 1.60 Mio | 2.83 Mio/s, fait.
    Résolution des deltas: 100% (3346/3346), fait.

Strangely I don't get this error when I use a different machine, so
maybe it depends if it's a 32bit/64bit build or version of Git or
something, but even on that other machine `git fsck` complains about
those bad dates.

I see that it's a fairly recent commit on embark (contrary to the
previous error quoted above which was about some old commit in
coffee-mode) so it might be easier to fix.

Omar, any chance you could fix these with a rebase.
[ Yes, I hate rebases for public branches and it's going to be a bit of
  a PITA to fix the clones we have on elpa.gnu.org (but the clones of
  those clones I have on various other machines 🙁) which track those
  branches, but it's arguably better in the long term.  ]


        Stefan