Re: having emacs-matlab in ELPA, finally. FSF paper signed

[Philip Kaludercic]

Uwe Brauer <oub@mat.ucm.es> writes:

> Hi
>
>
>> Uwe Brauer <oub@mat.ucm.es> writes:
>
>> OK, just ping me when you think the cleanup process is done, and I can
>> tell you if anything remains to be done before adding the package.
>
>
> Ok, we finished some weeks ago but also had to merge some branches with new 
> features. 
>
> I just recall that our repository now is in 
> https://github.com/mathworks/Emacs-MATLAB-Mode.git
>
> And we have it also in MELPA. As we discussed I would like to have it in
> ELPA (all authors signed the FSF papers). If it works as expected I
> might remove it from MELPA.
> The following two points are not entirely  clear to me:
>
>     1. The version numbering and the commits we push.
>
>        1. In MELPA every commit we push, will result in an updated MELPA
>           version. There version scheme is like for example in our case.
>            matlab-mode                    20241117.1628
>
>        2. I see that ELPA has something like this
>          aggressive-indent              1.10.0         available    gnu   
>          aggressive-indent              20230112.1300  available    melpa 
>         so is the GNU/EPLA version identical to the MELPA one
>
>     2. The procedure for MELPA is as follows.
>
>        1. MELPA itself dwells in github, so
>
>        2. I need to fork that repository, clone it
>
>        3. Add a branch,
>
>        4. Add a recipe file that looks like
>
> (matlab-mode
>  :fetcher github
>  :repo "mathworks/Emacs-MATLAB-Mode"
>  :files (:defaults
>          ("toolbox" "toolbox/*.m")
>          ("toolbox/+emacs" "toolbox/+emacs/*.m")
>          ("toolbox/+emacs/@Breakpoints" "toolbox/+emacs/@Breakpoints/*.m")
>          ("toolbox/+emacs/@EmacsServer" "toolbox/+emacs/@EmacsServer/*.m")
>          ("toolbox/+emacs/@Stack" "toolbox/+emacs/@Stack/*.m")
>          ("bin" "bin/*.sh")
>          (:exclude "matlab-maint.el")))
>
>         1. Commit and push
>
>         2. Open a pull-request.
>
> Now what is the procedure for ELPA, and is there anything like a recipe
> file? 

You don't have to do anything*, I just have to add a package
specification (similar to the "recipe file" for MELPA) to elpa.git.

* As soon as it works.  The main issues right now, are as you noticed
  that ELPA doesn't release a new tarball for every commit, but just
  when a new version is released.  We track this by checking for commits
  that bump the "Version" header in the main file (in your case
  matlab.el).  You currently don't have any version number, so the build
  fails.  I would suggest applying a change like this, if it doesn't
  break any assumptions you have regarding the minimal Emacs version:

diff --git a/matlab.el b/matlab.el
index 8ca0ee24a2..b82229a672 100644
--- a/matlab.el
+++ b/matlab.el
@@ -5,11 +5,7 @@
 ;; Maintainer: Eric M. Ludlam <eludlam@mathworks.com>
 ;; Created: 04 Jan 91
 ;; Keywords: MATLAB(R)
-;; Version:
-
-(defconst matlab-mode-version "5.0"
-  "Current version of MATLAB(R) mode.")
-
+;; Version: 5.0
 ;;
 ;; Copyright (C) 1997-2022 Eric M. Ludlam
 ;; Copyright (C) 1991-1997 Matthew R. Wette
@@ -50,6 +46,10 @@
 
 ;;; Code:
 
+(defconst matlab-mode-version (package-get-version)
+  "Current version of MATLAB(R) mode.")
+
+
 (require 'matlab-compat)
 (require 'matlab-syntax)
 (require 'matlab-scan)

  The other issue is that ELPA checks the copyright string and wants to
  see that all packages in GNU ELPA have their copyright assigned to the
  FSF.

  If you can fix these two things, then everything should go through.
  You can then decide to filter out files out of the final tarball by
  adding an .elpaignore file that lists what files to exclude.

> Thanks and regards
>
> Uwe Brauer