emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: having emacs-matlab in ELPA, finally. FSF paper signed


From: Stefan Kangas
Subject: Re: having emacs-matlab in ELPA, finally. FSF paper signed
Date: Sat, 23 Nov 2024 14:13:51 -0500

Uwe Brauer <oub@mat.ucm.es> writes:

>>>> "SK" == Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Philip Kaludercic <philipk@posteo.net> writes:
>>> +(defconst matlab-mode-version (package-get-version)
>>> +  "Current version of MATLAB(R) mode.")
>
>> We have tried to discourage the addition of such variables and commands,
>> given that one can always find that information by other means,
>> e.g. interactively with `describe-package` or from Lisp:
>
>>     (package-desc-version (cadr (assq 'foo package-alist)))
>
> So you want me use just that string
> well (package-desc-version (cadr (assq 'matlab-mode package-alist)))
> I presume
>
> in matlab.el (and matlab-mode.el)?

That's what I would do, indeed.  Well, I'd use this if you need the
string form:

    (package-version-join
     (package-desc-version (cadr (assq 'matlab-mode package-alist))))

Yeah, it's a bit of a mouthful.  Most packages don't bother, and just
rely on `describe-package`, I think.

That said, there's nothing wrong with keeping it around; it just seems
redundant now that you have a "Version" header.  I mostly mentioned it
for the record, and in case you wanted to get rid of some possible
redundancy.

(Personally, I'm not sure if the `matlab-show-version` command is needed
either given that we have `describe-package`.  In emacs.git, we tend to
make such `foo-package-version` commands obsolete.)

> What's about our current setting
>
> (defconst matlab-mode-version "6.2"
>   "Current version of MATLAB(R) mode.")
>
> Which we need for MELPA?

Hmm, are you sure that you need it for MELPA even with the addition of
the "Version" header?

In any case, this is an extremely minor nit either way.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]