[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/assess 38fc7829bc 42/95: Interpret nil to mean no faces
From: |
ELPA Syncer |
Subject: |
[elpa] externals/assess 38fc7829bc 42/95: Interpret nil to mean no faces. |
Date: |
Tue, 19 Jul 2022 15:57:32 -0400 (EDT) |
branch: externals/assess
commit 38fc7829bc3e3e36efa82931922adaa976d080c1
Author: Phillip Lord <phillip.lord@russet.org.uk>
Commit: Phillip Lord <phillip.lord@russet.org.uk>
Interpret nil to mean no faces.
When assessing faces at a point, nil for was being interpreted as an
empty list of faces, so was always true. Now, we interpret nil to mean
exactly no faces.
Closes #4
---
assess.el | 4 +++-
test/assess-test.el | 10 ++++++++--
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/assess.el b/assess.el
index 42b0769e46..5695066ca3 100644
--- a/assess.el
+++ b/assess.el
@@ -957,7 +957,9 @@ the copy of FILE will be in a different directory."
locations)))
;; make sure we have a list of faces
(faces
- (if (listp faces)
+ (if (and (listp faces)
+ ;; but not nil
+ (not (eq nil faces)))
faces
(list faces)))
;; make sure faces is as long as locations
diff --git a/test/assess-test.el b/test/assess-test.el
index dd59bcc2a5..11defd1b2d 100644
--- a/test/assess-test.el
+++ b/test/assess-test.el
@@ -464,6 +464,12 @@ This also tests the advice on string=."
(should
(get 'assess-discover-test-has-this-been-defined 'ert--test)))
-
-
+;; https://github.com/phillord/assess/issues/4
+(ert-deftest issue-4-has-type-face ()
+ "Test that no faces are present at point."
+ (should-not
+ (assess-face-at= "foo bar" 'fundamental-mode
+ "bar" 'font-lock-type-face))
+ (should-not
+ (assess-face-at= "def" 'python-mode "def" nil)))
;; #+end_src
- [elpa] externals/assess 1b01542ccd 20/95: Fontification testing., (continued)
- [elpa] externals/assess 1b01542ccd 20/95: Fontification testing., ELPA Syncer, 2022/07/19
- [elpa] externals/assess 2e556a62ae 22/95: Add new test file., ELPA Syncer, 2022/07/19
- [elpa] externals/assess 32a00524a8 24/95: Fix unused variable issues, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 3cf57afcaf 26/95: Merge pull request #1 from syohex/fix, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 00c794a516 29/95: Add package support., ELPA Syncer, 2022/07/19
- [elpa] externals/assess f490f18a18 32/95: Merge branch 'master' of github.com:phillord/sisyphus, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 0d079db1a7 34/95: Completed documentation., ELPA Syncer, 2022/07/19
- [elpa] externals/assess cab9fea7b8 28/95: Documentation for everything, ELPA Syncer, 2022/07/19
- [elpa] externals/assess f521db4101 36/95: Add sisyphus-discover, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 46290f163d 37/95: Add tests for discover., ELPA Syncer, 2022/07/19
- [elpa] externals/assess 38fc7829bc 42/95: Interpret nil to mean no faces.,
ELPA Syncer <=
- [elpa] externals/assess 818cf77258 27/95: Merge pull request #2 from syohex/minimum, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 880d519d6b 35/95: Update readme, add infojs., ELPA Syncer, 2022/07/19
- [elpa] externals/assess 216adb069c 47/95: Add assess-call.el, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 07bd7f8915 58/95: Doc fixes, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 739661405b 59/95: Add assess-robot.el and tests, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 9521b07480 71/95: Fix and Publish documentation statically, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 5aee8d7500 81/95: Mark some tests as failed on earlier emacs, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 0a3e94477a 78/95: Support all of Emacs 24 series, ELPA Syncer, 2022/07/19
- [elpa] externals/assess e5b0415126 85/95: Update README and release number, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 7a3189a587 86/95: Remove types and replace with convertors, ELPA Syncer, 2022/07/19