[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/assess 5aee8d7500 81/95: Mark some tests as failed on e
From: |
ELPA Syncer |
Subject: |
[elpa] externals/assess 5aee8d7500 81/95: Mark some tests as failed on earlier emacs |
Date: |
Tue, 19 Jul 2022 15:57:35 -0400 (EDT) |
branch: externals/assess
commit 5aee8d7500903de7fc460f61129ef9f979a68899
Author: Phillip Lord <phillip.lord@russet.org.uk>
Commit: Phillip Lord <phillip.lord@russet.org.uk>
Mark some tests as failed on earlier emacs
Emacs before 24.3 does not support advice, therefore, mark tests requiring
this as failing. Likewise, one test also depends on python fontification
which
is only active after 24.2
---
test/assess-call-test.el | 14 ++++++++++++++
test/assess-test.el | 13 +++++++++++--
2 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/test/assess-call-test.el b/test/assess-call-test.el
index 66da692039..10b48e793a 100644
--- a/test/assess-call-test.el
+++ b/test/assess-call-test.el
@@ -29,6 +29,15 @@
(require 'assess)
(require 'assess-call)
+(defun assess-call-no-advice ()
+ ;; Check by version number
+ (if (and
+ (= emacs-major-version 24)
+ (or (= emacs-minor-version 3)
+ (= emacs-minor-version 2)
+ (= emacs-minor-version 1)))
+ :failed :passed))
+
(defun assess-call-return-car (&rest args)
(car args))
@@ -36,6 +45,7 @@
(apply #'assess-call-return-car args))
(ert-deftest call-capture ()
+ :expected-result (assess-call-no-advice)
(should
(equal
'(((10 11 12) . 10))
@@ -45,6 +55,7 @@
(assess-call-return-car 10 11 12))))))
(ert-deftest call-capture-deep ()
+ :expected-result (assess-call-no-advice)
(should
(equal
'(((20 21 22) . 20))
@@ -57,6 +68,7 @@
(* a b))
(ert-deftest call-capture-twice ()
+ :expected-result (assess-call-no-advice)
(should
(equal
'(((3 4) . 12) ((1 2) . 2))
@@ -77,6 +89,7 @@
retn))
(ert-deftest assess-call-test-capture-fail ()
+ :expected-result (assess-call-no-advice)
(should-not
(assess-call-adviced-p 'assess-call-capture-multiply))
(should
@@ -144,6 +157,7 @@
The form that we are capturing should return the same value that
it would were it not instrumented, which was not true with
earlier versions of this library."
+ :expected-result (assess-call-no-advice)
(should
(= 4
(let ((rtn-from-form))
diff --git a/test/assess-test.el b/test/assess-test.el
index 79b1e6e84d..ecd4fb2dcf 100644
--- a/test/assess-test.el
+++ b/test/assess-test.el
@@ -27,8 +27,10 @@
;; #+begin_src emacs-lisp
(require 'load-relative)
(require 'assess)
-(require 'cl-lib)
-
+(unless (require 'cl-lib nil t)
+ (require 'cl)
+ (defalias 'cl-cdadr 'cdadr)
+ (defalias 'cl-loop 'loop))
;; #+end_src
;; ** Test Extraction
@@ -517,6 +519,13 @@ This also tests the advice on string=."
;; https://github.com/phillord/assess/issues/4
(ert-deftest issue-4-has-type-face ()
"Test that no faces are present at point."
+ :expected-result
+ ;; Emacs 24.2 just does not do this.
+ (if (and
+ (= emacs-major-version 24)
+ (or (= emacs-minor-version 2)
+ (= emacs-minor-version 1)))
+ :failed :passed)
(should-not
(assess-face-at= "foo bar" 'fundamental-mode
"bar" 'font-lock-type-face))
- [elpa] externals/assess cab9fea7b8 28/95: Documentation for everything, (continued)
- [elpa] externals/assess cab9fea7b8 28/95: Documentation for everything, ELPA Syncer, 2022/07/19
- [elpa] externals/assess f521db4101 36/95: Add sisyphus-discover, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 46290f163d 37/95: Add tests for discover., ELPA Syncer, 2022/07/19
- [elpa] externals/assess 38fc7829bc 42/95: Interpret nil to mean no faces., ELPA Syncer, 2022/07/19
- [elpa] externals/assess 818cf77258 27/95: Merge pull request #2 from syohex/minimum, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 880d519d6b 35/95: Update readme, add infojs., ELPA Syncer, 2022/07/19
- [elpa] externals/assess 216adb069c 47/95: Add assess-call.el, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 07bd7f8915 58/95: Doc fixes, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 739661405b 59/95: Add assess-robot.el and tests, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 9521b07480 71/95: Fix and Publish documentation statically, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 5aee8d7500 81/95: Mark some tests as failed on earlier emacs,
ELPA Syncer <=
- [elpa] externals/assess 0a3e94477a 78/95: Support all of Emacs 24 series, ELPA Syncer, 2022/07/19
- [elpa] externals/assess e5b0415126 85/95: Update README and release number, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 7a3189a587 86/95: Remove types and replace with convertors, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 5bac045b27 94/95: Update version, ELPA Syncer, 2022/07/19
- [elpa] externals/assess ac8ff1f928 39/95: Change all file names to assess., ELPA Syncer, 2022/07/19
- [elpa] externals/assess 4bf702a08a 43/95: Re-order to put macros first., ELPA Syncer, 2022/07/19
- [elpa] externals/assess e9344a55df 45/95: Move from ert to assess-discover, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 7409b103a3 46/95: Update .gitignore, ELPA Syncer, 2022/07/19
- [elpa] externals/assess e1b7740df5 55/95: Add unwind-protect to assess-call functions, ELPA Syncer, 2022/07/19
- [elpa] externals/assess 2335b8bd69 63/95: Remove old call-capture variable, ELPA Syncer, 2022/07/19