[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH 3/4] ob-clojure.el: Use :ns flag in org-src-edit
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH 3/4] ob-clojure.el: Use :ns flag in org-src-edit |
Date: |
Mon, 23 Apr 2018 11:26:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello,
address@hidden writes:
> * lisp/ob-clojure.el (org-babel-edit-prep:clojure): New function that
> sets the buffer's namespace to the value of :ns, if provided.
> (org-babel-edit-prep:clojurescript): Alias for
> org-babel-edit-prep:clojure.
Thank you.
> +(defun org-babel-edit-prep:clojure (babel-info)
> + (if-let* ((namespace (cdr (assq :ns (nth 2 babel-info)))))
> + (setq-local cider-buffer-ns namespace)))
Missing docstring. Also, please avoid `if-let*', which is non-standard,
AFAIK. You can use `pcase' however.
Regards,
--
Nicolas Goaziou
- [O] [PATCH 0/4] Clojure mode patches, roberthambrock, 2018/04/22
- [O] [PATCH 1/4] org-src.el: Fixed dynamic fontification bug, roberthambrock, 2018/04/22
- [O] [PATCH 2/4] ob-clojure.el: Add ClojureScript interface, roberthambrock, 2018/04/22
- [O] [PATCH 3/4] ob-clojure.el: Use :ns flag in org-src-edit, roberthambrock, 2018/04/22
- [O] [PATCH 4/4] ob-clojure.el: Add ClojureScript tangle language extension, roberthambrock, 2018/04/22
- Re: [O] [PATCH 0/4] Clojure mode patches, Nicolas Goaziou, 2018/04/23