[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH 4/4] ob-clojure.el: Add ClojureScript tangle language ext
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH 4/4] ob-clojure.el: Add ClojureScript tangle language extension |
Date: |
Mon, 23 Apr 2018 11:28:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello,
address@hidden writes:
> * lisp/ob-clojure.el (org-babel-tangle-langs-exts): Add ClojureScript
> to the supported language extensions.
Thank you. Some comments follow.
> (defvar org-babel-tangle-lang-exts)
> (add-to-list 'org-babel-tangle-lang-exts '("clojure" . "clj"))
> +(add-to-list 'org-babel-tangle-lang-exts '("clojurescript" . "cljs"))
>
> (defvar org-babel-default-header-args:clojure '())
> (defvar org-babel-header-args:clojure '((package . :any)))
Don't you need to also define
`org-babel-default-header-args:clojurescript' and
`org-babel-header-args:clojurescript' ?
Also, this entails a comment at the beginning of the library, IMO.
Regards,
--
Nicolas Goaziou
- [O] [PATCH 1/4] org-src.el: Fixed dynamic fontification bug, (continued)
- [O] [PATCH 1/4] org-src.el: Fixed dynamic fontification bug, roberthambrock, 2018/04/22
- [O] [PATCH 2/4] ob-clojure.el: Add ClojureScript interface, roberthambrock, 2018/04/22
- [O] [PATCH 3/4] ob-clojure.el: Use :ns flag in org-src-edit, roberthambrock, 2018/04/22
- [O] [PATCH 4/4] ob-clojure.el: Add ClojureScript tangle language extension, roberthambrock, 2018/04/22
- Re: [O] [PATCH 4/4] ob-clojure.el: Add ClojureScript tangle language extension,
Nicolas Goaziou <=
- Re: [O] [PATCH 0/4] Clojure mode patches, Nicolas Goaziou, 2018/04/23