[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] lisp/org-table.el: Allow named columns on lhs
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] lisp/org-table.el: Allow named columns on lhs |
Date: |
Sun, 23 Jul 2023 06:50:01 +0000 |
Gavin Downard <gavin.downard@runbox.com> writes:
>> Notice
>> "Double definition `%s=' in TBLFM line, please fix by hand"
>>
>> below. A bit more code is required to keep this sanity check for named
>> columns.
>>
>
> Oh, good catch. Specifically, I think this should be caught inside of
> `org-table-recalculate', where it catches conflicting direct column
> references (eg "$1") and end-relative column references ("$<").
Do we have any tests covering this part of the code?
>> `if-let' is not available in Emacs-26
>>
>
> Are you sure? It looks like `if-let' was introduced in Emacs 25.
In Emacs 26, we will need (require 'subr-x), but otherwise it is not a
problem to use `if-let'.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- [PATCH] lisp/org-table.el: Allow named columns on lhs, Gavin Downard, 2023/07/18
- Re: [PATCH] lisp/org-table.el: Allow named columns on lhs, Ihor Radchenko, 2023/07/19
- Re: [PATCH] lisp/org-table.el: Allow named columns on lhs, Max Nikulin, 2023/07/21
- Re: [PATCH] lisp/org-table.el: Allow named columns on lhs, Gavin Downard, 2023/07/21
- Re: [PATCH] lisp/org-table.el: Allow named columns on lhs, Max Nikulin, 2023/07/21
- Re: [PATCH] lisp/org-table.el: Allow named columns on lhs, Ihor Radchenko, 2023/07/22
- Re: [PATCH] lisp/org-table.el: Allow named columns on lhs, Max Nikulin, 2023/07/22
- Re: [PATCH] lisp/org-table.el: Allow named columns on lhs, Ihor Radchenko, 2023/07/22
Re: [PATCH] lisp/org-table.el: Allow named columns on lhs, Max Nikulin, 2023/07/22
Re: [PATCH] lisp/org-table.el: Allow named columns on lhs, Max Nikulin, 2023/07/24