emms-help
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [emms-help] Playback / cache issue with mpv backend


From: Pierre Neidhardt
Subject: Re: [emms-help] Playback / cache issue with mpv backend
Date: Mon, 02 Apr 2018 21:46:30 +0530
User-agent: mu4e 1.0; emacs 25.3.1

Found it:

https://github.com/emacs-helm/helm-emms/pull/10

> Performing the default action on a candidate from the "Music
> Directories" source adds files to the playlist as tracks with type
> playlist because helm-emms-add-files-to-playlist uses
> emms-add-file-playlist.
>
> In my case, I have no player configured for playlists, so this action
> causes an error: (error "Don’t know how to play track: (*track* (type
> . playlist) ....
>
> Note that emms-track caches information including the track type, which
> can exacerbate the problem by continuing to use the wrong type even if
> the track is later added with the correct type specified. This caching
> can also mask the problem if the track is added with the correct type
> before helm-emms adds it with the wrong type.
>
> I see no reason to assume the files in a directory are playlists, so
> this pull request replaces use of emms-add-file-playlist with
> emms-add-file.

Don't mind my bug report, it was completely misguided.

That said, I think Emms should be smarter here: I think it should detect
whether the target is a playlist or a track.  What about having just one
`emms-add-file` function then?

-- 
Pierre Neidhardt

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]