Re: Two very small bugs and a wish list

[Yoni Rabkin]

"Fran Burstall (Gmail)" <fran.burstall@gmail.com> writes:

> Having run emms-playlist-mode-shift-track under edebug, I find that C-o/i
> work perfectly if I comment out the form
>
>  (emms-with-inhibit-read-only-t
> (kill-line))
>
> which kills an extra line.

Yup, I'm seeing that. I'll need to account to how different people have
newline behavior set up in Emms.

Thank you.

>
> On Sat, 13 Jan 2024 at 09:55, Fran Burstall (Gmail) <fran.burstall@gmail.com>
> wrote:
>
>> Should have said: this is emacs 29.1 and emms fresh from melpa today
>> v20240112.2108.
>>
>> On Sat, 13 Jan 2024 at 09:51, Fran Burstall (Gmail) <
>> fran.burstall@gmail.com> wrote:
>>
>>> I am seeing this as well.  In a playlist buffer like this with point at
>>> at the start of the Track 1:
>>>
>>> Track 1
>>> Track 2
>>> Track 2
>>>
>>> I do C-o and get
>>>
>>> <empty line>
>>> Track 1
>>> Track 3
>>>
>>> and Track 2 has disappeared.  No tracks were playing at the time.
>>>
>>> ---Fran
>>>
>>>
>>>
>>> On Sat, 13 Jan 2024 at 09:22, Titus Müller <mail@titusmueller.de> wrote:
>>>
>>>> > I'm not seeing these issues. Can you please provide a step-by-step
>>>> > recipe to recreate this?
>>>>
>>>> Hm, that's strange. To be sure no other packages are responsible for the
>>>> behaviour, today I started Emacs with emacs -Q and used M-x load-file to
>>>> load emms-compat.el, emms.el, emms-source-file.el, emms-source-playlist.el
>>>> and emms-playlist.el. Then I used M-x emms-add-directory to add an album to
>>>> the playlist, switched to the playlist with M-x emms-playlist-mode-go and
>>>> there I used C-o and C-i to try to move the tracks around. I get the same
>>>> empty line and "nil:" error.
>>>>
>>>> In my elpa directory, the emms directory is called emms-20240112.2108.
>>>> Should I remove it and try to install again?
>>>>
>>>> ----- Ursprüngliche Nachricht vom 12.01.2024 -----
>>>> > Yoni Rabkin <yoni@rabkins.net> writes:
>>>> >
>>>> >> Titus Müller <mail@titusmueller.de> writes:
>>>> >>
>>>> >>> Thank you so much for adding this feature!
>>>> >>>
>>>> >>> I tested it a little.
>>>> >>>
>>>> >>> First time using emms-playlist-mode-shift-track-down: Works fine,
>>>> with
>>>> >>> the little drawback that it inserts a blank line below the downwards
>>>> >>> moved track, moving all the following tracks one line further down.
>>>> >>>
>>>> >>> Second, third, fourth time using emms-playlist-mode-shift-track-down
>>>> >>> in a row: Adds a line »nil:« above, I assume because trying to move
>>>> >>> the empty line up.
>>>> >>>
>>>> >>> Using emms-playlist-mode-shift-track-up correctly moves the upper
>>>> >>> track down, but instead of in turn moving the current track up to
>>>> >>> switch the two, it empties it's line, so what has been moved up, is
>>>> >>> deleted, and the track is now missing from the playlist.
>>>> >
>>>> > I'm not seeing these issues. Can you please provide a step-by-step
>>>> > recipe to recreate this?
>>>> >
>>>> >> It shouldn't be doing any of that. I need to fix all of those issues.
>>>> >>
>>>> >> Which version of Emacs are you on, by the way?
>>>> >>
>>>> >>> ----- Ursprüngliche Nachricht vom 09.01.2024 -----
>>>> >>>> Titus Müller <mail@titusmueller.de> writes:
>>>> >>>>
>>>> >>>>> (3) In emms-playlist-mode, it would be great to have a function to
>>>> >>>>> move a track one line up, and one to move a track one line down, to
>>>> >>>>> permanently (after saving the playlist) change the order of the
>>>> >>>>> playlist.
>>>> >>>>
>>>> >>>> This is now implemented in the main git repo, bound to C-i and C-o
>>>> in
>>>> >>>> playlist-mode.
>>>> >>>>
>>>> >>>> Note that these functions can be used to move the playing track as
>>>> well;
>>>> >>>> they shouldn't interfere.
>>>> >>>>
>>>> >>>> I probably missed some edge cases, so checking it out would be
>>>> >>>> appreciated. As always.
>>>> >>>
>>>>
>>>>
>>>>

-- 
   "Cut your own wood and it will warm you twice"