[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Findutils-patches] Patches to -type x,y,z

From: Bernhard Voelker
Subject: Re: [Findutils-patches] Patches to -type x,y,z
Date: Wed, 6 Apr 2016 10:31:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

On 03/08/2016 11:42 AM, Young Mo Kang wrote:
> Please find the attached patch files to enable -type x,y,z search.

Sorry for the late reply.
I thought a bit about the implementation and thought it'd be better
to avoid artificially creating the OR-ed predicates, and rather store
the wanted file types in an array and check for that in pred.c.
I think this should be faster, too.

The attached implements it like that.
I've also added extensive tests for the new feature.

@James: did you get green lights regarding FSF Copyright assignment?
Otherwise, or if you, Young, feel that my re-implementation is too far
away from your original, I can also set myself as author (and change
the "Co-authored-by: ..." to "Inspired by a proposal of ..." in the
commit msg).

Happy testing & have a nice day,

Attachment: 0001-find-support-list-of-file-types-for-type-and-xtype.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]