RE: [Freeipmi-devel] Re: [llnl-devel] New FreeIPMI API thouoghts

[Mike Haskell]

Who say's design by committee doesn't work?  :-)
Mike

-----Original Message-----
From: address@hidden
[mailto:address@hidden On Behalf
Of Albert Chu
Sent: Friday, December 05, 2003 11:31 AM
To: Anand Babu
Cc: address@hidden; address@hidden
Subject: Re: [Freeipmi-devel] Re: [llnl-devel] New FreeIPMI API
thouoghts

Hey AB,

> ipmi_lan_header_rq (IPMI_SESSION_AUTH_TYPE_STRAIGHT_PASSWD_KEY,
>    inbound_seq_num, session_id, passwd, 
> IPMI_SESSION_MAX_AUTH_CODE_LEN,    fn, lun, session_seq_num, 
> &rmcp_hdr, &session, &msg);
> ipmi_chassis_ctrl_rq (chassis_ctrl, &cmd);
> assemble_ipmi_lan_rq_pkt (rmcp_hdr, session, msg, &cmd, cmd_len, 
> lan_pkt, lan_pkt_len);
> 
> status = ipmi_lan_sendto (sockfd, lan_pkt, lan_pkt_len, 0, (struct
>          sockaddr *)&to_addr,  sizeof (struct sockaddr_in));

Now that you mention it, I like this better.  It separates the "lan
session" creation stuff from the "cmd" creation stuff.  Internally
within assemble_ipmi_lan_rq_pkt, we can do the marshalling, and 
assemble_ipmi_lan_rq_pkt returns the number of bytes written into
the buffer.

my_len = assemble_ipmi_lan_rq_pkt (rmcp_hdr, session, msg, &cmd,
cmd_len, lan_pkt, lan_pkt_len);
 
status = ipmi_lan_sendto (sockfd, lan_pkt, my_len, 0, (struct
         sockaddr *)&to_addr,  sizeof (struct sockaddr_in));

Al

--
Albert Chu
address@hidden
Lawrence Livermore National Laboratory





_______________________________________________
Freeipmi-devel mailing list
address@hidden
http://mail.nongnu.org/mailman/listinfo/freeipmi-devel