[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Freeipmi-devel] Patch for hex k_g keys in ipmipower, take 2

From: Albert Chu
Subject: Re: [Freeipmi-devel] Patch for hex k_g keys in ipmipower, take 2
Date: Fri, 27 Apr 2007 08:50:36 -0700 (PDT)
User-agent: SquirrelMail/1.4.6

> Levi Pearson wrote:
>> This version should address the issues from the review of the previous
>> patch.  I've tested this one a bit more and it seems pretty solid to me.
> This is probably a very uncommon use case: Since the "0x" prefix is used
> for specifying keys in hex format you cannot encode keys that actually
> start with a literal "0x" in string format. This is probably a very
> uncommon use case, but you should still fall back to hex syntax in this
> case. Otherwise format_kg() might format a key in a way that can't be
> read by parse_kg().

I had thought about this as well.  Thinking that perhaps an escape
character could be used to escape the '0x'.  But like you said, it is an
extremely unlikely use case and figured the tradeoff/effort wasn't worth


> Cheers,
> Ingo
> _______________________________________________
> Freeipmi-devel mailing list
> address@hidden

Albert Chu
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory

reply via email to

[Prev in Thread] Current Thread [Next in Thread]