Re: [Giftweb-discuss] color bug in util.php

[Matthew T. Jachimstal]

On Sat, 2003-01-18 at 23:08, Gregory Gee wrote:
>   There are missing starting quote from the body tag.  Only the
> bgcolor has quotes around it.

>   Should be
> 
>     if ($bgcolor!="") { echo " bgcolor=\"$bgcolor\""; }
>     if ($textcolor!="") { echo " \"textcolor=\"$textcolor\""; }
>     if ($linkcolor!="") { echo " \"link=\"$linkcolor\""; }
>     if ($alinkcolor!="") { echo " \"alink=\"$alinkcolor\""; }
>     if ($vlinkcolor!="") { echo " \"vlink=\"$vlinkcolor\""; }
> 

Actually, I think it should be:

    if ($bgcolor!="") { echo " bgcolor=\"$bgcolor\""; }
    if ($textcolor!="") { echo " textcolor=\"$textcolor\""; }
    if ($linkcolor!="") { echo " link=\"$linkcolor\""; }
    if ($alinkcolor!="") { echo " alink=\"$alinkcolor\""; }
    if ($vlinkcolor!="") { echo " vlink=\"$vlinkcolor\""; }

With the \" around only the $bgcolor, $textcolor, etc instead of around
textcolor=$textcolor, etc.

Correct me if I'm wrong. 

That code was actually contributed by someone else, and I didn't look at
it too closely. :)


>   Also, I have been trying to figure out the html layout.  It seems
> that every page is inside one large table.  Is this intended?  This
> makes a page header and footer not very easy to customize.

Yes, it is, and yes it makes things difficult. I'm not _real_ good with
HTML layout, and that's the best I could come up with. Maybe use frames
instead? Or something else?

Matthew

signature.asc
Description: This is a digitally signed message part