Re: [Giftweb-discuss] color bug in util.php

[Gregory Gee]

  Oops, didn't see those ones.  You're right.  That looks better.

> On Sat, 2003-01-18 at 23:08, Gregory Gee wrote:
>>   There are missing starting quote from the body tag.  Only the
>> bgcolor has quotes around it.
>
>>   Should be
>>
>>     if ($bgcolor!="") { echo " bgcolor=\"$bgcolor\""; }
>>     if ($textcolor!="") { echo " \"textcolor=\"$textcolor\""; }
>>     if ($linkcolor!="") { echo " \"link=\"$linkcolor\""; }
>>     if ($alinkcolor!="") { echo " \"alink=\"$alinkcolor\""; }
>>     if ($vlinkcolor!="") { echo " \"vlink=\"$vlinkcolor\""; }
>>
>
> Actually, I think it should be:
>
>     if ($bgcolor!="") { echo " bgcolor=\"$bgcolor\""; }
>     if ($textcolor!="") { echo " textcolor=\"$textcolor\""; }
>     if ($linkcolor!="") { echo " link=\"$linkcolor\""; }
>     if ($alinkcolor!="") { echo " alink=\"$alinkcolor\""; }
>     if ($vlinkcolor!="") { echo " vlink=\"$vlinkcolor\""; }
>
> With the \" around only the $bgcolor, $textcolor, etc instead of around
> textcolor=$textcolor, etc.
>
> Correct me if I'm wrong.
>
> That code was actually contributed by someone else, and I didn't look at
> it too closely. :)
>

-- 
Gregory Gee
address@hidden