gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: g_malloc / g_strdup in xgnokii_lowlevel.c


From: Pawel Kot
Subject: Re: g_malloc / g_strdup in xgnokii_lowlevel.c
Date: Sat, 18 Feb 2006 14:44:25 +0100

Hi,

On 2/18/06, Daniele Forsi <address@hidden> wrote:
> at lines 175-178 of xgnokii_lowlevel.c in InitModelInf()
> it seems to me that the two g_malloc's have no purpose
>
>         phoneMonitor.phone.version = g_malloc(sizeof(gdat.revision));
>         phoneMonitor.phone.revision = g_malloc(sizeof(gdat.revision));
>         phoneMonitor.phone.version = g_strdup(gdat.revision);
>         phoneMonitor.phone.revision = g_strdup(gdat.revision);

Agree. Seems unneeded.

take care
pkot
--
Pawel Kot
http://www.gnokii.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]