Re: Nokia 6155 on Gentoo 2006.1 with Gnokii 0.6.14 - some progress

[Mark Kirkwood]

Mark Kirkwood wrote:
> A second look shows that I was misled by a sea of MODULE_XXX_YYY 
> defines. We need module_param(var, type, perms), with 3 args instead 
> (see patch attached).
>
> I'll test drive it later, when I boot into 2.6.17 (but it sounds like I 
>  should concentrate on the libusb approach - right? - since this will 
> never work in 2.6.18....)

Well - spoke too soon, it turns out to be equally trivial to get 
nokia_dku2 to build under 2.6.18 (patch for 2.6.18 attached).

Cheers

Mark

*** nokia_dku2.c.orig   Mon Aug 28 10:36:54 2006
--- nokia_dku2.c        Sun Dec 17 14:07:20 2006
***************
*** 39,45 ****
        static int debug;
  #endif
  
! #include "usb-serial.h"
  #include "nokia_dku2.h"
  
  /*
--- 39,45 ----
        static int debug;
  #endif
  
! #include <linux/usb/serial.h>
  #include "nokia_dku2.h"
  
  /*
***************
*** 160,164 ****
  MODULE_DESCRIPTION(DRIVER_DESC);
  MODULE_LICENSE("GPL");
  
! MODULE_PARM(debug, "i");
  MODULE_PARM_DESC(debug, "Debug enabled or not");
--- 160,164 ----
  MODULE_DESCRIPTION(DRIVER_DESC);
  MODULE_LICENSE("GPL");
  
! module_param(debug, int, S_IRUGO);
  MODULE_PARM_DESC(debug, "Debug enabled or not");