gnuboot-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v1 16/18] website-build: check.sh: help: fix program name.


From: Denis 'GNUtoo' Carikli
Subject: [PATCH v1 16/18] website-build: check.sh: help: fix program name.
Date: Sat, 25 May 2024 20:25:51 +0200

The GNU Coding Standards has the following in the chapter "4.8.1
--version"[1]:
    The program’s name should be a constant string; don’t compute it
    from argv[0]. The idea is to state the standard or canonical name
    for the program, not its file name. There are other ways to find
    out the precise file name where a command is found in PATH.
[1]https://www.gnu.org/prep/standards/standards.html#g_t_002d_002dversion

This fixes that.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
---
 website-build/check.sh | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/website-build/check.sh b/website-build/check.sh
index 7c1426c..363dd43 100755
--- a/website-build/check.sh
+++ b/website-build/check.sh
@@ -19,9 +19,11 @@ EX_USAGE=64
 
 tarball=""
 
-help()
+usage()
 {
-       echo "Usage: $0 [options]"
+       progname="$1"
+
+       echo "Usage: ${progname} [options]"
        echo ""
        echo "Available options:"
        echo -e "\t-h, --help"
@@ -76,12 +78,12 @@ run_tests()
 # shellcheck disable=SC2166 # We want to make operator precedence
 # clear.
 if [ $# -eq 1 ] && [ "$1" = "-h" -o "$1" == "--help" ] ; then
-       help
+       usage "check.sh"
        exit 0
 elif [ $# -eq 2 ] && [ "$1" = "-t" -o "$1" = "--tarball" ] ; then
        tarball="$(realpath "$2")"
        run_tests "${tarball}"
 else
-       help
+       usage "check.sh"
        exit ${EX_USAGE}
 fi
-- 
2.41.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]