Re: [PATCH v1 14/18] website-build: configure: require awk.

[Adrien 'neox' Bourmault]

Le samedi 25 mai 2024 à 20:25 +0200, Denis 'GNUtoo' Carikli a écrit :
> Without that fix, running configure fails both without and and with
> guix:
>     $ guix shell -C \
>       bash coreutils findutils git \
>       grep gzip pandoc sed tar  -- \
>       ./configure --disable-guix --disable-lighttpd
>     [...]
>     config.status: creating Makefile
>     ./config.status: line 920: awk: command not found
>     sed: couldn't write 24 items to stdout: Broken pipe
>     config.status: error: could not create Makefile
> 
>     $ guix shell -C \
>       bash coreutils grep guix sed tar -- \
>       ./configure --disable-lighttpd
>     [...]
>     config.status: creating Makefile
>     ./config.status: line 920: awk: command not found
>     sed: couldn't write 24 items to stdout: Broken pipe
>     config.status: error: could not create Makefile
> 
> And in both tests above we need coreutils, grep, sed and tar anyway as
> without that configure doesn't even get to the point of failing to
> find the other utilities:
>     $ guix shell -C bash -- ./configure
>     [...]
>     ./configure: line 492: sed: command not found
>     ./configure: line 491: expr: command not found
>     ./configure: line 492: sed: command not found
>     ./configure: line 506: sed: command not found
>     : error: cannot create .lineno; rerun with a POSIX shell
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> ---
>  website-build/configure.ac | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/website-build/configure.ac b/website-build/configure.ac
> index 43d3300..6ae2c4f 100644
> --- a/website-build/configure.ac
> +++ b/website-build/configure.ac
> @@ -68,6 +68,10 @@ AC_ARG_WITH([untitled-path],
>  AM_CONDITIONAL( [WANT_UNTITLED_PATH], [test x"$UNTITLED_PATH" != x""])
>  
>  # Check dependencies
> +AC_CHECK_PROG([FOUND_AWK], [awk], [awk])
> +AS_IF([test x"$FOUND_AWK" = x""],
> +      [AC_MSG_ERROR([awk was not found in PATH ($PATH)])])
> +
>  AC_CHECK_PROG([FOUND_REALPATH], [realpath], [realpath])
>  AS_IF([test x"$FOUND_REALPATH" = x""],
>        [AC_MSG_ERROR([realpath was not found in PATH ($PATH)])])

Acked-by: Adrien 'neox' Bourmault <neox@gnu.org>

signature.asc
Description: This is a digitally signed message part