Re: [PATCH v1 06/18] website-build: use a less common port.

[Adrien 'neox' Bourmault]

Le samedi 25 mai 2024 à 20:25 +0200, Denis 'GNUtoo' Carikli a écrit :
> When working on multiple websites the same time, having every website
> using the port 8080 by default isn't very convenient.
> 
> In addition here we need a number that is somewhat easy to remember
> and possibly meaningful for each website, so in general that not easy
> to choose.
> 
> But in the case of GNU Boot we can find a scheme because:
> - GNU Boot supports only x86 machines for now,
> - the GM45 ThinkPads are probably the most well supported by GNU
>   Boot and also well known machines,
> - that the GM45 ThinkPads use Intel CPUs,
> - that 8086 is frequently used as vendor ID for Intel,
> 
> so here we can simply use 8086 as it's meaningful and at least very
> easy to remember at least for people working in that field.
> 
> In addition for people not familiar with writing drivers for x86
> computers, it could also reminds of a CPU also from Intel.
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> ---
>  website-build/README       | 2 +-
>  website-build/configure.ac | 4 ++--
>  website-build/serve.sh     | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/website-build/README b/website-build/README
> index fdff5d4..c916683 100644
> --- a/website-build/README
> +++ b/website-build/README
> @@ -13,7 +13,7 @@ $ ./autogen.sh
>  $ ./configure
>  $ make test
>  
> -Then you can point a browser to
> http://localhost:8080/software/gnuboot/web/ or
> +Then you can point a browser to
> http://localhost:8086/software/gnuboot/web/ or
>  to http://localhost:PORT/software/gnuboot/web/ if you changed the port
> through
>  ./configure options.
>  
> diff --git a/website-build/configure.ac b/website-build/configure.ac
> index 1aea32b..3036ee5 100644
> --- a/website-build/configure.ac
> +++ b/website-build/configure.ac
> @@ -41,9 +41,9 @@ AM_CONDITIONAL( [WANT_LIGHTTPD], [test x"$lighttpd" =
> x"yes"])
>  AC_ARG_WITH([lighttpd-port],
>    [AS_HELP_STRING([--with-lighttpd-port=PORT],
>                    [Use a custom TCP port for lighttpd tests instead of the
> -                   default one (8080).])],
> +                   default one (8086).])],
>    [LIGHTTPD_PORT=$withval],
> -  [LIGHTTPD_PORT=8080])
> +  [LIGHTTPD_PORT=8086])
>  
>  # --with-rsync-destination
>  AC_ARG_WITH([rsync-destination],
> diff --git a/website-build/serve.sh b/website-build/serve.sh
> index 35c8761..a826c69 100755
> --- a/website-build/serve.sh
> +++ b/website-build/serve.sh
> @@ -30,7 +30,7 @@ basedir="$(dirname $(realpath $0))"
>  
>  tarball="$1"
>  
> -lighttpd_port=8080
> +lighttpd_port=8086
>  if [ $# -eq 2 ] ; then
>      lighttpd_port="$2"
>  fi

Acked-by: Adrien 'neox' Bourmault <neox@gnu.org>

signature.asc
Description: This is a digitally signed message part