Re: [PATCH v1 08/18] website-build: check.sh: make it pass shellcheck.

[Adrien 'neox' Bourmault]

Le samedi 25 mai 2024 à 20:25 +0200, Denis 'GNUtoo' Carikli a écrit :
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> ---
>  tests/lint             | 3 ++-
>  website-build/check.sh | 4 +++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/lint b/tests/lint
> index 02e625b..ce9d405 100755
> --- a/tests/lint
> +++ b/tests/lint
> @@ -65,7 +65,8 @@ run_shellcheck \
>      resources/scripts/misc/guix.sh \
>      resources/scripts/tasks/distclean.sh \
>      tests/distclean \
> -    tests/lint
> +    tests/lint \
> +    website-build/check.sh
>  
>  printf "+---------------------+\n"
>  printf "| Lint tests done     |\n"
> diff --git a/website-build/check.sh b/website-build/check.sh
> index 5c421d0..7c1426c 100755
> --- a/website-build/check.sh
> +++ b/website-build/check.sh
> @@ -73,11 +73,13 @@ run_tests()
>             "${tarball}"
>  }
>  
> +# shellcheck disable=SC2166 # We want to make operator precedence
> +# clear.
>  if [ $# -eq 1 ] && [ "$1" = "-h" -o "$1" == "--help" ] ; then
>         help
>         exit 0
>  elif [ $# -eq 2 ] && [ "$1" = "-t" -o "$1" = "--tarball" ] ; then
> -       tarball="$(realpath $2)"
> +       tarball="$(realpath "$2")"
>         run_tests "${tarball}"
>  else
>         help

Acked-by: Adrien 'neox' Bourmault <neox@gnu.org>

signature.asc
Description: This is a digitally signed message part