[PATCH v1 0/3] Workaround / fix guix git authenticate

[Denis 'GNUtoo' Carikli]

Hi,

Apparently we hit a bug in guile-git or guix[1] with guix git
authenticate: our introduction commit was too big. So this serie
hopefuly workarounds the issue.

Also note that the following command was wrong:
$ guix git authenticate $(git rev-parse HEAD) \
  "E23C 26A5 DEEE C5FA 9CDD  D57A 57BC 26A3 6871 16F6" \
  -k origin/keyring

Here it only works if the commit is signed with neox's key which
defeats an important feature of guix git authenticate.

It's probably a leftover from some tests I did when adjusting
dde4223088cbfe8a347626638d32902ba2323b25 ("Fix .guix-authorizations
for Denis 'GNUtoo' Carikli.").

This patch set also adds a command that works.

Also for the bug #66268, we still lack some information and
understanding on what trigger it or doesn't trigger it as there is
some cache (in memory) involved. So the patch sets a threshold of 4000
B for the metadata (commit message, short summary, From, etc) hoping
to catch the issue but we're not completely sure it will not have
false negative.

Another possibility would be to use guix git authenticate to do the
tests but I'm less confident that it could detect the conditions of
the bug as a fresh clone and a local git repository might be very
different even if they have the same commit IDs as the git object can
be packed differently. And requiring to push the commits just to
detect if there is a potential issue is probably not very practical,
so the tests will probably be skipped.

Since we also cannot block the development of GNU Boot because of this
issue, I'm sending these patches now. For instance we also need to
integrate neox's patches for the website after these fixes or
workaround.

Also note that these patches pass the checkpatch.scm test, though for
now chekcpatch.scm assumes that what we feed it are git patches, so
for instance it doesn't work yet with this cover letter.

References:
[1]https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66268

Denis 'GNUtoo' Carikli (3):
  guix git authenticate: fix expected output.
  guix git authenticate: workaround broken command due to guix/guile-git
    bug #66268.
  Add checkpatch.scm script and require maintainers to run it.

 Makefile.am                 |   1 +
 manual/gnuboot.texi         |   7 +-
 scripts/checkpatch.scm      | 622 ++++++++++++++++++++++++++++++++++++
 tests/checkpatch            |  47 +++
 tests/lint                  |   1 +
 website/pages/contribute.md |  31 ++
 6 files changed, 704 insertions(+), 5 deletions(-)
 create mode 100755 scripts/checkpatch.scm
 create mode 100755 tests/checkpatch


base-commit: c85fbae78f398d12d1df1f27b97e39838c4e08e3
-- 
2.46.0