gnuboot-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v1 1/3] guix git authenticate: fix expected output.


From: Denis 'GNUtoo' Carikli
Subject: [PATCH v1 1/3] guix git authenticate: fix expected output.
Date: Tue, 26 Nov 2024 19:37:22 +0100

The first version of the 3f9b38739fe8e8f03c948356157ca211c8485111
patch ("manual: Add section about building GNU Boot.)" and the GNU
Boot 0.1 RC4 announce have the following guix git authenticate
command:
    $ guix git authenticate $(git rev-parse HEAD) \
      "E23C 26A5 DEEE C5FA 9CDD  D57A 57BC 26A3 6871 16F6" \
      -k origin/keyring

This is wrong as HEAD is not an introductory commit and it can only
work if it is signed by the "E23C 26A5 DEEE C5FA 9CDD D57A 57BC 26A3
6871 16F6" key which defeats many of the important features of guix
git authenticate like the ability to delegate trust to multiple
people.

This command was probably used by me during early tests as I didn't
have neox's key to sign commit and that my key was invalid (see the
commit dde4223088cbfe8a347626638d32902ba2323b25 "Fix
.guix-authorizations for Denis 'GNUtoo' Carikli." for more details)
and it was probably kept as it appeared to work.

Since the expected way to use guix git authenticate is with an
introductory commit, the output of the command is then predictable and
it should be exactly the same than the one described in the GNU Boot
manual.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
---
 manual/gnuboot.texi | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/manual/gnuboot.texi b/manual/gnuboot.texi
index 1ec9e0f1..d5cd9eab 100644
--- a/manual/gnuboot.texi
+++ b/manual/gnuboot.texi
@@ -856,14 +856,11 @@ bf2b91df54aa71ecbfab891d32000ad2d6af6093 \
 -k origin/keyring
 @end example
 
-It should then print something like that:
+It should then print the following text:
 @example
-guix git: successfully authenticated commit 
dde4223088cbfe8a347626638d32902ba2323b25
+guix git: successfully authenticated commit 
bf2b91df54aa71ecbfab891d32000ad2d6af6093
 @end example
 
-the commit hash (here @samp{dde4223088cbfe8a347626638d32902ba2323b25})
-might be different for you.
-
 @xref{Invoking guix git authenticate,,,guix,GNU Guix manual} or
 @uref{https://guix.gnu.org/en/blog/2024/authenticate-your-git-checkouts/,the
 Authenticate your Git checkouts! Guix blog post} for more details.
-- 
2.46.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]