[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/5] resources: grub: config: (ab)use shellcheck to check
|
From: |
Denis 'GNUtoo' Carikli |
|
Subject: |
Re: [PATCH v1 2/5] resources: grub: config: (ab)use shellcheck to check it. |
|
Date: |
Thu, 26 Dec 2024 18:38:38 +0100 |
On Fri, 13 Dec 2024 14:58:48 +0100
Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> wrote:
> While the grub configuration file format is very different from real
> shell scripts, the similarities are enough to make it pass shellcheck
> with very few adjustements.
This only works in (recent) Guix, with Trisquel 11 (aramo) and PureOS
10 (byzantium) this fails with the following error:
> In resources/grub/config/grub.cfg line 23:
> set prefix=(memdisk)/boot/grub
> ^-- SC1088 (error): Parsing stopped here. Invalid use of
> parentheses?
>
> For more information:
> https://www.shellcheck.net/wiki/SC1088 -- Parsing stopped here. Invalid
> use...
> [ !! ] resources/grub/config/grub.cfg failed
So either the patch needs to fix this (by disabling SC1088) and
subsequent errors or it needs to be dropped.
Denis.
pgpxtTiArWQyu.pgp
Description: OpenPGP digital signature
- [PATCH v1 0/5] Fix LVM2 again., Denis 'GNUtoo' Carikli, 2024/12/13
- [PATCH v1 2/5] resources: grub: config: (ab)use shellcheck to check it., Denis 'GNUtoo' Carikli, 2024/12/13
- Re: [PATCH v1 2/5] resources: grub: config: (ab)use shellcheck to check it.,
Denis 'GNUtoo' Carikli <=
- [PATCH v1 4/5] resources: grub: config: fix non-working regexp., Denis 'GNUtoo' Carikli, 2024/12/13
- [PATCH v1 1/5] website: history: Add git history of website-build., Denis 'GNUtoo' Carikli, 2024/12/13
- [PATCH v1 5/5] resources: grub: config: unify dev and devices variables., Denis 'GNUtoo' Carikli, 2024/12/13
- [PATCH v1 3/5] resources: grub: config: fix wrong dev/device variable., Denis 'GNUtoo' Carikli, 2024/12/13
- Re: [PATCH v1 0/5] Fix LVM2 again., Adrien 'neox' Bourmault, 2024/12/14