Re: [PATCH v1 2/5] resources: grub: config: (ab)use shellcheck to check it.

[Adrien 'neox' Bourmault]

Le jeudi 26 décembre 2024 à 18:38 +0100, Denis 'GNUtoo' Carikli a
écrit :
> On Fri, 13 Dec 2024 14:58:48 +0100
> Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> wrote:
> 
> > While the grub configuration file format is very different from
> > real
> > shell scripts, the similarities are enough to make it pass
> > shellcheck
> > with very few adjustements.
> This only works in (recent) Guix, with Trisquel 11 (aramo) and PureOS
> 10 (byzantium) this fails with the following error:
> > In resources/grub/config/grub.cfg line 23:
> > set prefix=(memdisk)/boot/grub
> >            ^-- SC1088 (error): Parsing stopped here. Invalid use of
> > parentheses?
> > 
> > For more information:
> >   https://www.shellcheck.net/wiki/SC1088 -- Parsing stopped here.
> > Invalid use...
> > [ !! ] resources/grub/config/grub.cfg failed
> 
> So either the patch needs to fix this (by disabling SC1088) and
> subsequent errors or it needs to be dropped.
> 
> Denis.

This patch had been merged since Dec, 15th. I tested it with recent
Guix indeed, so didn't remarked a problem with it. We then need to fix
it with a new patch.

signature.asc
Description: This is a digitally signed message part