AW: [gnugo-devel] Symmetry corrections

[Teun Burgers]

I ran make owl_rotall in the regression subdir with
3 versions of gnugo:

3.3.9 unpatched
3.3.9 with Gunnar's patch
3.3.9 with Nando's revision of Gunnar's patch:

3.3.9 has 23 reorientation inconsistencies.
Gunnar's patch brings that down to 17.
Nando's revision brings it back to 23, though
the inconsistencies are somewhat different from unpatched 3.3.9.

The problem in Nando's patch with regard to reorientation invariance
is this line I think:

+               && list->pattern_list[bottom].move < top_move

Here are the inconsistency tables for the 3 versions.
Horizontal axis is orientation number. Vertical axis is test
number in owl.tst. f=failure, p=pass, F=FAILURE, P=PASS.

3.3.9: 23 inconsistent
      0 1 2 3 4 5 6 7
  66  f f P f P P f f
  70  p p p p p p F p
 109  p p p p F p F F
 118  f P P f f P P f
 125  p p F p p F p p
 208  f P P f f f P P
 244  p F F p p F F p
 262  p F p F p p p p

3.3.9 with Gunnar's patch: 17 inconsistent
      0 1 2 3 4 5 6 7
  23  P f f f P f f f
  66  f f P f P P f f
  70  p F p p p p p p
 118  f P P f f P P f
 125  p p F p p F p p
 244  p F F p p F F p
 262  p F p p p p p p

3.3.9 with Nando's revision of Gunnar's patch: 23 inconsistent
      0 1 2 3 4 5 6 7
  23  f f f f f f f P
  66  P f f P P f f P
  70  p F F p p p F F
 118  f P P f f P P f
 125  p p F p p F p p
 208  f P P f f f P P
 244  p F F p p F F p

Teun