[gnugo-devel] semeai_3_15.1a

[Gunnar Farneback]

I may have missed some messages to the list, but I haven't seen any
discussion about the patch semeai_3_15.1a. Here are some comments:

> -  struct dragon_data *d = &(dragon[pos]);
> -  struct dragon_data2 *d2 = &(dragon2[d->id]);
> +  struct dragon_data *d;
> +  struct dragon_data2 *d2;
>    
> +  d = &(dragon[pos]);
> +  d2 = &(dragon2[d->id]);

I don't see why this would be better.

> RCS file: /cvsroot/gnugo/gnugo/engine/optics.c,v
> retrieving revision 1.63
> diff -u -r1.63 optics.c
> --- engine/optics.c   2 Jan 2003 00:23:28 -0000       1.63
> +++ engine/optics.c   4 Jan 2003 03:09:46 -0000
> @@ -425,7 +425,7 @@
>      }
>    }
>    
> -  if (0 && (debug & DEBUG_EYES)) {
> +  if (1 && (debug & DEBUG_EYES)) {

I'm rather negative to having this on by default. When I do owl tuning
I frequently use DEBUG_EYES and then the output for the primary
domains are badly cluttering up the traces. Should we split off this
as a separate debug flag?

> -  /* If NULL, set the move pointer to a local dummy variable so we can
> -   * avoid checking for NULL everywhere else.
> -   */
> -  if (!move)
> -    move = &dummy_move;
> -  

Why remove this? I think it's a big win not having to test whether
move is NULL, like this,

> -      *move = PASS_MOVE;
> +      if (move) *move = PASS_MOVE;

some 15 times in the function.

/Gunnar