Re: [gnugo-devel] semeai_3_15.1a

[Arend Bayer]

Dan wrote:

> Gunnar wrote:
> > Why remove this? I think it's a big win not having to test whether
> > move is NULL, like this,
> >
> > > -      *move = PASS_MOVE;
> > > +      if (move) *move = PASS_MOVE;
> >
> > some 15 times in the function.
>
> I didn't change this. I don't see why this is a big win. One way you
> test (move) being a null pointer, the other way you set a dummy
> variable only to discard the result. In any case, it's misleading to
> point out that this happens 15 times in the function since this will
> probably happen only once per call to do_owl_analyze_semeai.

But Gunnar's point was that you have this code 15 times in the function,
making the code even longer to read than it already is. (Of course
do_owl_analyze_semeai is approximately not performance relevant at all.)

Arend