Re: [Gnump3d-devel] [PATCH] Updates to the tag cache

[Stuffed Crust]

On Sat, Feb 19, 2005 at 09:30:29PM +0000, Steve Kemp wrote:
>   Sometimes I get complaints that the code is slow, especially in a
>  recursive playlist generation on an old machine.  I'm not sure whether
>  this will help people in that situation or not, still it looks good
>  and works for us so I've committed it too.

The code is quite inefficent in places; I've started marking places to 
go over later, but the worst is taken care of now.

>   Yes .. Some people have suggested showing new files is more useful
>  than new directories.  (I guess this is a personal thing, I only add
>  new files in new directories so these are synonymous for me).

Attached is a patch to do just this.   It retains the old "new_days" 
logic, but it will also test to see if the directory/file is newer than 
the tag cache was last loaded/modified.  

It works pretty well in my testing so far.  The only catch remaining is 
actually a larger problem -- if there are no ID3 tags, we don't use the 
requested format at all, so naturally we don't include the $NEW thing, 
when we really could. 

I'm not sure what to do about this..

I'll continue to hack on other stuff this weekend if I can.

 - Solomon
-- 
Solomon Peachy                                   ICQ: 1318344
Melbourne, FL                                    JID: address@hidden
Quidquid latine dictum sit, altum viditur

gnump3d.diff
Description: Text document

pgpsv0pJrQEWV.pgp
Description: PGP signature