Re: [GNUnet-developers] using $TMPDIR instead of /tmp

[Nils Gillmann]

Schanzenbach, Martin transcribed 19K bytes:
> Well the preprocessor simply replaces all occurrences of the define in the 
> code with what you specified.
> So I guess it will work. But _if_ GNUNET_DISK_mktemp returns an allocated 
> string, then this leaks memory.
> You'd need to free the string returned by the call after it is used.

gnunet-herlper-transport-wlan-dummy.c, line 496 and following unlinks the FIFOs,
isn't that enough?

In any case the last commit was bad, but I'm trying.

> BR
> Martin
> 
> > On 7. May 2018, at 10:03, Nils Gillmann <address@hidden> wrote:
> > 
> > Nils Gillmann transcribed 3.7K bytes:
> >> Nils Gillmann transcribed 3.0K bytes:
> >>> Schanzenbach, Martin transcribed 4.1K bytes:
> >>>> Hey.
> >>>> 
> >>>> I don't thing the "//" should be an issue (albeit unnecessary).
> >>> 
> >>> Yes, you are right, I just tested it.
> >>> 
> >>>> Maybe the directory is not created?
> >> 
> >> Okay. I just grepped for "tmp" in the directory (src/transport) and it is
> >> one of the testsuites where the path is hardcoded. Earlier in this thread
> >> we talked about changing it, but I did not consider parts of the testsuite
> >> which are written in C that use /tmp...
> >> 
> >> I have no time to fix it today.
> >> I think it's okay that the testsuite crashes occasionally, so we should 
> >> just
> >> fix the hardcoded paths now.
> > 
> > I've just started looking into our C code, and C in general, more.
> > In src/transport/gnunet-helper-transport-wlan-dummy.c
> > we define 2 fifo files (FIFO_FILE1, FIFO_FILE2). Those are currently
> > #define FIFO_FILE1 "/tmp/test-transport/api-wlan-p1/WLAN_FIFO_in"
> > #define FIFO_FILE1 "/tmp/test-transport/api-wlan-p1/WLAN_FIFO_out"
> > 
> > Would
> > 
> > #define FIFO_FILE1 GNUNET_DISK_mktemp("test-transport/api-wlan-p1/") 
> > "WLAN_FIFO_in"
> > 
> > work? the tests are still failing with this, but it seems like the right 
> > directories
> > and files are created.
> > 
> > test-suite.log (one file still had "/tmp" but in the right location, via 
> > GNUNET_DISK_mktemp:
> > 
> > =================================================
> >   gnunet 0.11.0: src/transport/test-suite.log
> > =================================================
> > 
> > # TOTAL: 55
> > # PASS:  49
> > # SKIP:  4
> > # XFAIL: 0
> > # FAIL:  2
> > # XPASS: 0
> > # ERROR: 0
> > 
> > .. contents:: :depth: 2
> > 
> > SKIP: test_transport_address_switch_tcp
> > =======================================
> > 
> > May 07 07:43:00-582453 nat-25226 WARNING upnpc failed to create port mapping
> > May 07 07:43:00-582555 nat-25226 WARNING upnpc failed to create port mapping
> > May 07 07:43:00-586782 nat-25230 WARNING upnpc failed to create port mapping
> > May 07 07:43:00-586836 nat-25230 WARNING upnpc failed to create port mapping
> > ............................May 07 07:43:28-550419 
> > test_transport_address_switch_tcp-25204 WARNING Testcase timed out
> > May 07 07:43:28-550546 test_transport_address_switch_tcp-25204 WARNING Test 
> > did not work, as peers didn't switch (flawed testcase)!
> > 
> > SKIP test_transport_address_switch_tcp (exit status: 77)
> > 
> > SKIP: test_transport_address_switch_udp
> > =======================================
> > 
> > May 07 07:43:29-987399 transport-udp-25255 WARNING We received a sending 
> > delay of 4289 ms for DK5W
> > May 07 07:43:30-312551 transport-udp-25255 WARNING We received a sending 
> > delay of 4289 ms for DK5W
> > May 07 07:43:30-615122 nat-25261 WARNING upnpc failed to create port mapping
> > May 07 07:43:30-615809 nat-25261 WARNING upnpc failed to create port mapping
> > May 07 07:43:30-618851 nat-25264 WARNING upnpc failed to create port mapping
> > May 07 07:43:30-618928 nat-25264 WARNING upnpc failed to create port mapping
> > ....May 07 07:43:34-137925 transport-25255 WARNING It took us 3183 ms to 
> > send 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:34-683575 transport-25255 WARNING It took us 3412 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:35-115098 transport-25255 WARNING It took us 3526 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:35-489559 transport-25255 WARNING It took us 3583 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:35-835496 transport-25255 WARNING It took us 3612 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:36-167183 transport-25255 WARNING It took us 3618 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:36-491733 transport-25255 WARNING It took us 3625 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:36-812649 transport-25255 WARNING It took us 3629 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:37-131821 transport-25255 WARNING It took us 3631 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:37-450052 transport-25255 WARNING It took us 3624 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:37-767875 transport-25255 WARNING It took us 3624 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:38-085482 transport-25255 WARNING It took us 3616 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:38-402974 transport-25255 WARNING It took us 3617 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:38-720397 transport-25255 WARNING It took us 3609 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:39-037834 transport-25255 WARNING It took us 3609 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:39-355247 transport-25255 WARNING It took us 3601 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:39-672687 transport-25255 WARNING It took us 3594 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:39-990115 transport-25255 WARNING It took us 3586 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:40-307479 transport-25255 WARNING It took us 3578 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:40-624915 transport-25255 WARNING It took us 3570 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:40-942477 transport-25255 WARNING It took us 3562 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:41-259930 transport-25255 WARNING It took us 3555 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:41-577395 transport-25255 WARNING It took us 3547 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:41-894826 transport-25255 WARNING It took us 3539 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:42-212196 transport-25255 WARNING It took us 3531 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:42-529641 transport-25255 WARNING It took us 3523 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:42-847013 transport-25255 WARNING It took us 3516 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:43-164358 transport-25255 WARNING It took us 3508 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:43-481742 transport-25255 WARNING It took us 3500 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:43-799086 transport-25255 WARNING It took us 3492 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:44-116482 transport-25255 WARNING It took us 3485 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:44-433858 transport-25255 WARNING It took us 3469 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:44-751066 transport-25255 WARNING It took us 3461 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:45-385635 transport-25255 WARNING It took us 3770 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:45-544278 transport-25255 WARNING It took us 3604 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:45-782322 transport-25255 WARNING It took us 3516 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:46-060020 transport-25255 WARNING It took us 3469 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:46-357545 transport-25255 WARNING It took us 3441 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:46-665023 transport-25255 WARNING It took us 3423 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:46-977444 transport-25255 WARNING It took us 3411 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:47-292388 transport-25255 WARNING It took us 3401 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:47-608397 transport-25255 WARNING It took us 3391 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:47-925138 transport-25255 WARNING It took us 3383 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:48-242355 transport-25255 WARNING It took us 3375 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:48-559630 transport-25255 WARNING It took us 3367 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:48-876932 transport-25255 WARNING It took us 3367 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:49-194289 transport-25255 WARNING It took us 3359 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:49-511676 transport-25255 WARNING It took us 3343 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:49-828962 transport-25255 WARNING It took us 3336 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:50-463606 transport-25255 WARNING It took us 3645 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:50-622286 transport-25255 WARNING It took us 3478 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:50-860334 transport-25255 WARNING It took us 3391 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:51-138021 transport-25255 WARNING It took us 3344 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:51-435536 transport-25255 WARNING It took us 3316 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:51-743034 transport-25255 WARNING It took us 3298 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:52-055451 transport-25255 WARNING It took us 3286 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:52-370367 transport-25255 WARNING It took us 3275 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:52-686423 transport-25255 WARNING It took us 3266 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:53-003068 transport-25255 WARNING It took us 3258 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:53-320191 transport-25255 WARNING It took us 3250 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:53-637493 transport-25255 WARNING It took us 3242 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:53-955073 transport-25255 WARNING It took us 3242 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:54-272558 transport-25255 WARNING It took us 3226 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:54-589951 transport-25255 WARNING It took us 3219 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:54-907352 transport-25255 WARNING It took us 3211 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:55-224748 transport-25255 WARNING It took us 3203 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:55-542145 transport-25255 WARNING It took us 3195 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:55-859530 transport-25255 WARNING It took us 3188 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:56-176951 transport-25255 WARNING It took us 3179 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:56-494289 transport-25255 WARNING It took us 3172 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:56-811628 transport-25255 WARNING It took us 3156 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:57-128992 transport-25255 WARNING It took us 3148 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:57-446348 transport-25255 WARNING It took us 3140 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > .May 07 07:43:57-763622 transport-25255 WARNING It took us 3132 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:58-081010 transport-25255 WARNING It took us 3125 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:58-398395 transport-25255 WARNING It took us 3117 ms to send 
> > 2600/2664 bytes to DK5W (1, udp)
> > May 07 07:43:58-581816 test_transport_address_switch_udp-25239 WARNING 
> > Testcase timed out
> > May 07 07:43:58-581934 test_transport_address_switch_udp-25239 WARNING Test 
> > did not work, as peers didn't switch (flawed testcase)!
> > 
> > SKIP test_transport_address_switch_udp (exit status: 77)
> > 
> > SKIP: test_transport_address_switch_http
> > ========================================
> > 
> > May 07 07:44:00-650827 nat-25297 WARNING upnpc failed to create port mapping
> > May 07 07:44:00-653529 nat-25297 WARNING upnpc failed to create port mapping
> > May 07 07:44:00-654786 nat-25299 WARNING upnpc failed to create port mapping
> > May 07 07:44:00-655803 nat-25299 WARNING upnpc failed to create port mapping
> > ............................May 07 07:44:28-615255 
> > test_transport_address_switch_http-25274 WARNING Testcase timed out
> > May 07 07:44:28-615366 test_transport_address_switch_http-25274 WARNING 
> > Test did not work, as peers didn't switch (flawed testcase)!
> > 
> > SKIP test_transport_address_switch_http (exit status: 77)
> > 
> > SKIP: test_transport_address_switch_https
> > =========================================
> > 
> > May 07 07:44:30-701806 nat-25337 WARNING upnpc failed to create port mapping
> > May 07 07:44:30-702063 nat-25337 WARNING upnpc failed to create port mapping
> > May 07 07:44:30-752393 nat-25342 WARNING upnpc failed to create port mapping
> > May 07 07:44:30-752491 nat-25342 WARNING upnpc failed to create port mapping
> > ............................May 07 07:44:58-647589 
> > test_transport_address_switch_https-25309 WARNING Testcase timed out
> > May 07 07:44:58-647706 test_transport_address_switch_https-25309 WARNING 
> > Test did not work, as peers didn't switch (flawed testcase)!
> > 
> > SKIP test_transport_address_switch_https (exit status: 77)
> > 
> > FAIL: test_plugin_udp
> > =====================
> > 
> > May 07 07:45:08-815979 test-plugin-transport-25427 ERROR Could not copy 
> > hostkey `test_plugin_hostkey.ecc' to destination 
> > `/tmp/guix-build-gnunet-git1.drv-0/gnunet//test-gnunetd-plugin-transport//.local/share/gnunet//private_key.ecc'.
> >  Exiting.
> > FAIL test_plugin_udp (exit status: 1)
> > 
> > FAIL: test_plugin_unix
> > ======================
> > 
> > May 07 07:45:08-842954 test-plugin-transport-25446 ERROR Could not copy 
> > hostkey `test_plugin_hostkey.ecc' to destination 
> > `/tmp/guix-build-gnunet-git1.drv-0/gnunet//test-gnunetd-plugin-transport//.local/share/gnunet//private_key.ecc'.
> >  Exiting.
> > FAIL test_plugin_unix (exit status: 1)
> > 
> > 
> > 
> > But I don't think the issue is with those files, they are known to the 
> > testsuite
> > and it doesn't care where the files are. There are more "/tmp" in 
> > src/transport to fix.
> > 
> > 
> >>>> BR
> >>>> 
> >>>>> On 7. May 2018, at 07:59, Nils Gillmann <address@hidden> wrote:
> >>>>> 
> >>>>> Nils Gillmann transcribed 1.8K bytes:
> >>>>>> Christian Grothoff transcribed 3.9K bytes:
> >>>>>>> On 05/06/2018 08:34 PM, Nils Gillmann wrote:
> >>>>>>>> Christian Grothoff transcribed 2.9K bytes:
> >>>>>>>>> On 05/05/2018 09:58 PM, Nils Gillmann wrote:
> >>>>>>>>>> Anyways I just had some time to work on this, could you read
> >>>>>>>>>> 5f627ce1a78f662d928fa6c73a90342d8bff5cf3 and tell me if I 
> >>>>>>>>>> understood
> >>>>>>>>>> the conversation we had here and your small commit right?
> >>>>>>>>> 
> >>>>>>>>> Yes, you got it perfectly right.
> >>>>>>>>> 
> >>>>>>>> 
> >>>>>>>> I've changed the config files, now the problem for us in Nix and Guix
> >>>>>>>> will be that the silly maximum unix path length will be hit quiet 
> >>>>>>>> often...
> >>>>>>>> at least for the Guix build chroot when the chroot is in 
> >>>>>>>> /tmp/guix-build-gnunet-git1.drv-0/
> >>>>>>>> 
> >>>>>>>> The $GNUNET_TMP then gives you diretories like 
> >>>>>>>> /tmp/guix-build-gnunet-git1.drv-0/gnunet/WAHTEVER-HERE/GOES/NOTHING
> >>>>>>>> where previously they just landed in /tmp iirc.
> >>>>>>>> 
> >>>>>>>> We should make it possible to set the value of GNUNET_TMP before 
> >>>>>>>> make check,
> >>>>>>>> for example via the equivalent of export GNUNET_TMP="/tmp"; make 
> >>>>>>>> check.
> >>>>>>>> 
> >>>>>>>> It's quiet unfortunate with the length..
> >>>>>>> 
> >>>>>>> Have you considered re-defining the maximum path length? Given that 
> >>>>>>> you
> >>>>>>> are a distro, you should be able to recompile everything necessary
> >>>>>>> (kernel, libc) with simply a larger value, right?
> >>>>>> 
> >>>>>> This time it wasn't the path length. We need to fix some parts of the
> >>>>>> test suite to adopt to the new (dynamic) locations of the test folders.
> >>>>>> 
> >>>>>> I knew this, but I was preoccupied.
> >>>>>> 
> >>>>>> I can't do anything today, feel free to revert 
> >>>>>> 9fbda6db66bf8dc074de6c8792f369801e4e5999
> >>>>>> or fix the test suites that are affected. I myself can think of fixes 
> >>>>>> tomorrow afternoon/evening.
> >>>>>> For now the testsuite is broken with this.
> >>>>> 
> >>>>> One fixed, a couple more to go.
> >>>>> 
> >>>>> 
> >>>>> FAIL: test_plugin_unix
> >>>>> ======================
> >>>>> 
> >>>>> May 07 05:37:28-321787 test-plugin-transport-25451 ERROR Could not copy 
> >>>>> hostkey `test_plugin_hostkey.ecc' to destination 
> >>>>> `/tmp/guix-build-gnunet-git1.drv-0/gnunet//test-gnunetd-plugin-transport//.local/share/gnunet//private_key.ecc'.
> >>>>>   Exiting.
> >>>>> FAIL test_plugin_unix (exit status: 1)
> >>>>> 
> >>>>> 
> >>>>> ^ should it be $GNUNET_TMP/foo or ${GNUNET_TMP}foo ? The two forward 
> >>>>> slashes are irritating.
> >>>>> 
> >>>>>> _______________________________________________
> >>>>>> GNUnet-developers mailing list
> >>>>>> address@hidden
> >>>>>> https://lists.gnu.org/mailman/listinfo/gnunet-developers
> >>>>> 
> >>>>> _______________________________________________
> >>>>> GNUnet-developers mailing list
> >>>>> address@hidden
> >>>>> https://lists.gnu.org/mailman/listinfo/gnunet-developers
> >>>> 
> >>> 
> >>> 
> >> 
> >> _______________________________________________
> >> GNUnet-developers mailing list
> >> address@hidden
> >> https://lists.gnu.org/mailman/listinfo/gnunet-developers
>