[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Two small questions about some components

From: Alessio Vanni
Subject: Two small questions about some components
Date: Tue, 20 Apr 2021 23:31:01 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)


I was investigating something in the codebase and found two things I'd
like to ask clarifications for. They are small and there is no need to
send two different mails, hence the subject of this mail.

1. I was looking at common_logging.c and found this:

static enum GNUNET_ErrorType
get_type (const char *log)
  if (NULL == log)
  if (0 == strcasecmp (log, _ ("DEBUG")))

  /* ...Other lines omitted for brevity... */


which is used during the logging component's initialization.

The question is: is there a reason why the argument is compared with the
gettext-ized version of each "type"?
>From a "user interface" point of view, one would expect for the
following call to have the same effect regardless of the current locale:

GNUNET_log_setup("component", "WARNING", NULL);

but according to the above function, unless I'm missing something
obvious, if the current locale contains a translation for "WARNING",
then the actual log level will be different than the desired one.


2. The `gnunet-config' tool in its current implementation, always writes
the full configuration to file after changing something and writes only
the modified parts when using the `-w' switch.

I think the behaviour should be swapped, as writing the whole
configuration will cause obsolete values to persist and potentially hard
to diagnose problems to appear, e.g. version X requires a certain value
to work around an issue, found after release and which version X+1
fixes, so the config change is not required, but users with modified
configs will still load the "wrong" value.

The patch to change the flag meaning is a one-liner, but first I'd like
to ask if maybe there was already some discussion about this behaviour,
or maybe even something about changing gnunet-config, so that I don't
submit a useless patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]