[gnurl] 172/282: Curl_is_ASCII_name: handle a NULL argument

[gnunet]

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit 1d1e9e8ad7a5f35818dc7072e6fbe8a76a93e018
Author: Daniel Stenberg <address@hidden>
AuthorDate: Thu Feb 27 11:06:14 2020 +0100

    Curl_is_ASCII_name: handle a NULL argument
    
    Make the function tolerate a NULL pointer input to avoid dereferencing
    that pointer.
    
    Follow-up to efce3ea5a85126d
    Detected by OSS-Fuzz
    Reviewed-By: Steve Holme
    Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20907
    Fixes #4985
    Closes #4986
---
 lib/smtp.c | 2 --
 lib/url.c  | 4 ++++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/smtp.c b/lib/smtp.c
index a87e6126a..79499e6d4 100644
--- a/lib/smtp.c
+++ b/lib/smtp.c
@@ -1773,8 +1773,6 @@ static CURLcode smtp_parse_address(struct connectdata 
*conn, const char *fqma,
        and send the host name using UTF-8 rather than as 7-bit ACE (which is
        our preference) */
   }
-  else
-    host->name = NULL;
 
   /* Extract the local address from the mailbox */
   *address = dup;
diff --git a/lib/url.c b/lib/url.c
index 85cdd5336..47fc66aed 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -1438,8 +1438,12 @@ void Curl_verboseconnect(struct connectdata *conn)
  */
 bool Curl_is_ASCII_name(const char *hostname)
 {
+  /* get an UNSIGNED local version of the pointer */
   const unsigned char *ch = (const unsigned char *)hostname;
 
+  if(!hostname) /* bad input, consider it ASCII! */
+    return TRUE;
+
   while(*ch) {
     if(*ch++ & 0x80)
       return FALSE;

-- 
To stop receiving notification emails like this one, please contact
address@hidden.