[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnurl] 175/282: smtp: fix memory leak on exit path
From: |
gnunet |
Subject: |
[gnurl] 175/282: smtp: fix memory leak on exit path |
Date: |
Wed, 01 Apr 2020 14:30:40 +0200 |
This is an automated email from the git hooks/post-receive script.
ng0 pushed a commit to branch master
in repository gnurl.
commit 81ade13c373c9569074e6f881fe9348123a7ed7c
Author: Daniel Stenberg <address@hidden>
AuthorDate: Thu Feb 27 14:37:40 2020 +0100
smtp: fix memory leak on exit path
Detected by Coverity. CID 1418139. "leaked_storage: Variable 'from'
going out of scope leaks the storage it points to"
Closes #4990
---
lib/smtp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/smtp.c b/lib/smtp.c
index 79499e6d4..77fcd5afc 100644
--- a/lib/smtp.c
+++ b/lib/smtp.c
@@ -612,8 +612,10 @@ static CURLcode smtp_perform_mail(struct connectdata *conn)
converting the host name to an IDN A-label if necessary */
result = smtp_parse_address(conn, data->set.str[STRING_MAIL_AUTH],
&address, &host);
- if(result)
+ if(result) {
+ free(from);
return result;
+ }
/* Establish whether we should report SMTPUTF8 to the server for this
mailbox as per RFC-6531 sect. 3.1 point 4 and sect. 3.4 */
--
To stop receiving notification emails like this one, please contact
address@hidden.
- [gnurl] 160/282: smtp: Support the SMTPUTF8 extension in the MAIL command, (continued)
- [gnurl] 160/282: smtp: Support the SMTPUTF8 extension in the MAIL command, gnunet, 2020/04/01
- [gnurl] 172/282: Curl_is_ASCII_name: handle a NULL argument, gnunet, 2020/04/01
- [gnurl] 169/282: libssh: improve known hosts handling, gnunet, 2020/04/01
- [gnurl] 174/282: gtls: Fixed compilation when using GnuTLS < 3.5.0, gnunet, 2020/04/01
- [gnurl] 173/282: RELEASE-NOTES: Corrected the link to issue #4892, gnunet, 2020/04/01
- [gnurl] 176/282: runtests: restore the command log, gnunet, 2020/04/01
- [gnurl] 154/282: smtp: Added UTF-8 mailbox tests to verify existing behaviour, gnunet, 2020/04/01
- [gnurl] 167/282: test1323: Added the missing 'unit test' feature requirement in the test case, gnunet, 2020/04/01
- [gnurl] 177/282: tests: fix Python 3 compatibility of smbserver.py, gnunet, 2020/04/01
- [gnurl] 171/282: RELEASE-NOTES: synced, gnunet, 2020/04/01
- [gnurl] 175/282: smtp: fix memory leak on exit path,
gnunet <=
- [gnurl] 183/282: TODO: curl --proxycommand, gnunet, 2020/04/01
- [gnurl] 179/282: ci/tests: align Azure Pipeline job names with each other, gnunet, 2020/04/01
- [gnurl] 182/282: smtp: overwriting 'from' leaks memory, gnunet, 2020/04/01
- [gnurl] 186/282: md4: Use non-deprecated functions in mbedTLS >= 2.7.0, gnunet, 2020/04/01
- [gnurl] 180/282: ci/tests: Increase timeouts of Windows builds due to new tests, gnunet, 2020/04/01
- [gnurl] 184/282: pause: force-drain the transfer on unpause, gnunet, 2020/04/01
- [gnurl] 181/282: CIfuzz: switch off 'dry_run' mode, gnunet, 2020/04/01
- [gnurl] 178/282: ci/tests: Add Windows builds via Azure Pipelines using Docker, gnunet, 2020/04/01
- [gnurl] 191/282: runtests: fix output to command log, gnunet, 2020/04/01
- [gnurl] 187/282: md5: Use pointer notation for array parameters in GnuTLS implementation, gnunet, 2020/04/01