Re: NSBrowser patch

[David Ayers]

Serg Stoyan wrote:

> Hi everybody!
>
> This a NSBrowser patch changes behaviour of setSeparatesColumns
> method. 
Very nice!
Here's  minor suggestion.

Cheers,
Dave


--- NSBrowser.m.org     Sat Sep 28 23:09:35 2002
+++ NSBrowser.m Sat Sep 28 23:16:49 2002
@@ -1099,6 +1099,7 @@
 {
   NSBrowserColumn *bc;
   NSScrollView    *sc;
+  NSBorderType    bt;
   int             i, columnCount;
 
   // if this flag already set or browser is titled -- do nothing
@@ -1106,28 +1107,17 @@
        return;
 
   columnCount = [_browserColumns count];
-  if (flag)
-       {
-         for (i = 0; i < columnCount; i++)
-               {
-                 bc = [_browserColumns objectAtIndex: i];
-                 sc = [bc columnScrollView];
-                 [sc setBorderType:NSBezelBorder];
-               }
-       }
-  else
+  bt = flag ? NSBezelBorder : NSNoBorder;
+  for (i = 0; i < columnCount; i++)
     {
-         for (i = 0; i < columnCount; i++)
-               {
-                 bc = [_browserColumns objectAtIndex: i];
-                 sc = [bc columnScrollView];
-                 [sc setBorderType:NSNoBorder];
-               }
-       }
-  
-      _separatesColumns = flag;
+       bc = [_browserColumns objectAtIndex: i];
+       sc = [bc columnScrollView];
+       [sc setBorderType:bt];
+    }
+
+  _separatesColumns = flag;
   [self setNeedsDisplay:YES];
-      [self tile];
+  [self tile];
 }
 
 /** Returns YES if the title of a column is set to the string value of