Re[3]: [NSDecimalNumber numberWithDouble:x]

[Manuel Guesdon]

On Tue, 13 Jan 2004 13:20:57 +0100 (CET) Manuel Guesdon <address@hidden> wrote:

 >| On Mon, 12 Jan 2004 11:06:31 -0700 Adam Fedor <address@hidden> wrote:
 >| 
 >|  >| 
 >|  >| On Monday, January 12, 2004, at 10:53 AM, David Ayers wrote:
 >|  >| 
 >|  >| >>> Hmm.. we may not really need to test against the concrete classes 
 >in 
 >|  >| >>> the numberWith*: methods as long as we never use them internally 
 >and 
 >|  >| >>> as long as we don't care about code that gets the classes via 
 >|  >| >>> NSClassFromString and class those methods.  I'd say it's an edge 
 >|  >| >>> case.  (But I haven't tested what could go wrong.)
 >|  >| >>>
 >|  >| >> I think you only need to test the concrete class.
 >|  >| >
 >|  >| > I'm pretty sure the implementations in NSNumber must test for the 
 >|  >| > *abstract* NSNumber class (and should/could arguably also test the 
 >|  >| > concrete class corresponding to the type supplied).
 >|  >| >
 >|  >| >
 >|  >| 
 >|  >| Oops. Sorry, that's what I meant to say (abstract, NOT concrete).
 >| 
 >| OK. Il' do the stuff.

Commited.

Manuel

-- 
______________________________________________________________________
Manuel Guesdon - OXYMIUM <address@hidden>
14 rue Jean-Baptiste Clement  -  93200 Saint-Denis  -  France
Tel: +33 1 4940 0999  -  Fax: +33 1 4940 0998