Re: NSButtonCell value, contents and cell type implementation rewritten

[Gregory John Casamento]

As always, please ensure that older revisions of NSButton are properly
unarchived if/when this change is applied.

Thanks, GJC

--- Alexander Malmberg <address@hidden> wrote:

> Quentin Mathé wrote:
> > Well, here is the NSButtonCell.m patch but without the new methods 
> > disposition in order to ease the comparison between the previous 
> > NSButtonCell.m version and this new version…
> 
> Thanks! This is much easier to review. :)
> 
> > hmm, Alexander, is this ok to commit ?
> 
> No. :)
> 
> The cell type-related changes seem a bit odd. Could you explain why this 
> is the right thing to do?
> 
> > --- 269,388 ----
> > 
> >   - (void) setTitle: (NSString*)aString
> ...
> > !   ASSIGN(_contents, aString);
> 
> This should be ASSIGNCOPY, and likewise in the other methods for setting 
> the title/alternate title.
> 
> For the new implementations of set*Value: in NSButtonCell to work 
> properly, you'll need to remove or rework the implementation of these 
> methods in NSButton.
> 
> There seem to be some issues with redisplaying an NSButton after calling 
> these methods. Exactly where the redisplay is done is the subject of 
> future cleanups, but it does need to be done somewhere (ie. calling 
> [NSButton -set*Value:] must somehow result in a -setNeedsDisplay: on the 
> button if the state changes).
> 
> 
> Also, note that this changes the current behavior of NSButton in some 
> important ways. It's no longer possible to set the title using 
> -setStringValue:. This is correct, but it will break apps (Matt Rice and 
> I have cleaned up some of it, but there are still apps known to break). 
> Thus, I'm not sure whether it's appropriate to commit a change like this 
> close to a release. It's a matter or release-policy, though. I'll send a 
> more general mail to the list soon about this; this shouldn't be 
> committed until that has been resolved.
> 
> - Alexander Malmberg
> 
> 
> _______________________________________________
> Gnustep-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnustep-dev
> 


=====
Gregory John Casamento 
-- CEO/President Open Logic Corp. (A Maryland Corporation)
#### Maintainer of Gorm for GNUstep.