[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Remove objc_mutex usage from gnustep-base
From: |
Niels Grewe |
Subject: |
[PATCH] Remove objc_mutex usage from gnustep-base |
Date: |
Wed, 20 Jan 2010 19:09:18 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hello all,
attached is a small patch that replaces all objc_mutexes in gnustep-base
with pthread_mutexes (save for the runtime mutex, of course). NSLock and
friends already use pthreads and I don't think there is anything to be
gained by sticking to the old runtime-threading layer in other places
(the new runtime doesn't even export objc_mutex_(de)allocate() anymore).
This also has the added benefit that (slightly faster) non-recursive
mutexes can be used in a few places, where they're just protecting
simple lookup or update operations on some table. As a downside, the
GSAllocateMutexAt() function from GSObjCRuntime.h had to go (but, apart
from the fact that using objc_mutexes shouldn't really be encouraged,
nobody seems to be using it).
I verified that the testsuite still passes for -base after the change
and I didn't notice any problems in day-to-day usage. Still, I'd really
appreciate somebody taking a closer look.
I'd also like to ask about whom to contact regarding copyright
assignment. I know that this is a rather insignificiant (and repetitive)
contribution, so it might not be strictly needed, but just in caseā¦
kind regards,
Niels
gsbase-pthreads.diff
Description: Text Data
signature.asc
Description: Digital signature
- [PATCH] Remove objc_mutex usage from gnustep-base,
Niels Grewe <=