Re: [PATCH] GSXML: Respect XML catalogs

[Yavor Doganov]

В Tue, 16 Feb 2010 18:17:23 +0100, Niels Grewe написа:
> some months back, somebody complained that gnustep-base took ages for
> them to build on a machine without network access. The problem was that
> the gsdoc DTDs were not yet installed and autogsdoc was trying to fetch
> them over the net, making it wait for a timeouts quite a while. libxml2
> does support a feature called xml-catalogs for such situations, allowing
> you to remap xml PUBLIC/SYSTEM identifiers to new (local) urls.
> 
> Recently, I took a look at GSXML and how it does handle DTD resolution.
> It turns out that it is overriding DTD resolution in a manner that
> bypasses catalogs. If a DTD is not installed to a location we explicitly
> search, it will always be fetched from the original url. Attached is a
> patch that corrects that by adding the DTDs GNUstep is resolving
> internally to the catalog and running libxml2's builtin lookup function
> afterwards. In theory, this should not break anything, but as always I
> might have screwed up slightly somewhere.

FWIW, I tested this patch (rebased against 1.19.3) and it works nicely.  
I plan to include it in the Debian package with the next upload (1.20.0), 
to help the Ubuntu people (there is no problem for Debian since the 
autobuilders build only arch-dependent packages).

Is there any chance to get it reviewed/approved/committed upstream?