Re: [Gnustep-cvs] r30370 - in /libs/gui/trunk: ChangeLog Headers/Additions/GNUstepGUI/GSTheme.h Source/GSThemeMenu.m Source/NSMenu.m

[Fred Kiefer]

Hi Greg,

could you please explain the purpose of this change? Up to now we tried
to keep any actual processing out of the GSTheme class and mostly had
drawing code here. This is not the case for your change. What
functionality are you trying to achieve in your theme?
Wouldn't it be better to achieve something similar by adding a
NSInterfaceStyle distinction into the NSApplication rightMouseDown:
method? And will your future change also work with the toolbar clip item
calling this method?

Fred

Am 13.05.2010 00:47, schrieb Gregory Casamento:
> Author: gcasa
> Date: Thu May 13 00:47:10 2010
> New Revision: 30370
> 
> URL: http://svn.gna.org/viewcvs/gnustep?rev=30370&view=rev
> Log:
>       * Headers/Additions/GNUstepGUI/GSTheme.h: Added method 
>       rightMouseMenu:forEvent: to allow theming of transient and
>       context menus.
>       * Source/GSThemeMenu.m: Implementation of method 
>       rightMouseMenu:forEvent: to allow theming of transient and
>       context menus.
>       * Source/NSMenu.m: use the theming code implemented above instead
>       of rendering the menu directly.
> 
> Modified:
>     libs/gui/trunk/ChangeLog
>     libs/gui/trunk/Headers/Additions/GNUstepGUI/GSTheme.h
>     libs/gui/trunk/Source/GSThemeMenu.m
>     libs/gui/trunk/Source/NSMenu.m