[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePa
From: |
Fred Kiefer |
Subject: |
Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m |
Date: |
Sat, 15 Jan 2011 19:46:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 |
I fully agree with Greg, the changed patch should be applied.
Thank your for your work German!
Fred
Am 15.01.2011 17:40, schrieb Gregory Casamento:
> Shouldn't we go ahead and apply this patch? It looks like it does the
> trick and it also does things were was suggested earlier in
> NSMenuView.m.
>
> GC
>
> On Fri, Jan 14, 2011 at 2:02 PM, Germán Arias <address@hidden> wrote:
>> On vie, 2011-01-14 at 16:11 +0100, Fred Kiefer wrote:
>>> Hi German,
>>>
>>> your latest patch looks very promising to me. What I didn't understand
>>> is the line
>>> + else
>>> + {
>>> + [[self keyWindow] makeMainWindow];
>>> + }
>>>
>>> When there is already a main Window, shouldn't we just keep that?
>>> I will have a closer look at the whole patch over the weekend.
>>>
>>> Thank you for your contribution
>>> Fred
>>>
>>
>> I thought that this was necessary for the apps that were not prepared to
>> have the menu in window. But it was a bad argument, the problem is that
>> we need to save the main window in the metod -hide:, too. Otherwise the
>> windows are order out and we lose the main window, and method
>> -deactivate: don't save the main window, because there isn't. This is
>> the same that NSApp do for key window, save the key window at methods
>> -hide and -deactivate. Attached the new patch.
>>
>> Regards.
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m, (continued)
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m, Wolfgang Lux, 2011/01/11
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m, Gregory Casamento, 2011/01/11
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m, Germán Arias, 2011/01/11
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m, Gregory Casamento, 2011/01/13
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m, Fred Kiefer, 2011/01/13
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m, Gregory Casamento, 2011/01/13
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m, Germán Arias, 2011/01/13
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m, Fred Kiefer, 2011/01/14
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m, Germán Arias, 2011/01/14
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m, Gregory Casamento, 2011/01/15
- Re: [Gnustep-cvs] r31864 - in /libs/gui/trunk: ChangeLog Source/NSSavePanel.m,
Fred Kiefer <=